Hello Anbazhagan, (apologies if Anbazhagan is not your given name -- I tried to google both "Anbazhagan" and "Baraneedharan", and it seems like "Baraneedharan" is your given name,)
On 02/29/16 01:09, Anbazhagan, Baraneedharan wrote: > Could you please help to merge these changes? Thanks. The patch that you sent was corrupt. I don't think you can use outlook.com for sending patches -- it corrupts patches. Please send your patches with a Mail User Agent that does not corrupt patches. So, I tried to reconstruct this patch manually for you. Then I noticed that the patch had already been committed -- Chao Zhang committed it as 447f73dbfe. Unfortunately, the metadata is not correct on the patch. When a patch is applied from the mailing list with the "git am" command, then git takes the authorship of the patch from the patch email, automatically. However, when a patch is reconstructed manually, to git it doesn't differ from a locally authored patch. So if you just commit it as usual, then the "Author:" meta-datum in git will reflect the local developer, not the original author of the patch. Therefore, in such cases, "git commit" must be invoked like this: git commit --author="Anbazhagan, Baraneedharan <[email protected]>" Now, the Signed-off-by label at the end of the commit message is alright, so the authorship info is not lost after all. But, since we've now moved to git, we should respect that it records "Author:" and "Committer:" separately in the metadata (unlike SVN). Summary: - Anbazhagan, please send patches with a sane Mail User Agent, - Chao Zhang, please pass the --author option to "git commit" when reconstructing patches manually. Thanks Laszlo > > From: Zhang, Chao B [mailto:[email protected]] > Sent: Sunday, February 21, 2016 6:58 PM > To: Anbazhagan, Baraneedharan <[email protected]>; [email protected] > Subject: RE: [PATCH] SecurityPkg: Change TPM MMIO range attribute > > Reviewed-by: Chao Zhang > <[email protected]<mailto:[email protected]>> > > > > > > Thanks & Best regards > Chao Zhang > > From: Anbazhagan, Baraneedharan [mailto:[email protected]] > Sent: Friday, February 19, 2016 6:15 AM > To: [email protected]<mailto:[email protected]> > Cc: Zhang, Chao B > Subject: [PATCH] SecurityPkg: Change TPM MMIO range attribute > > Changes made to TrEE SMM module is not ported to TCG2 SMM module > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Baraneedharan Anbazhagan > <[email protected]<mailto:[email protected]>> > --- > SecurityPkg/Tcg/Tcg2Smm/Tpm.asl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/SecurityPkg/Tcg/Tcg2Smm/Tpm.asl b/SecurityPkg/Tcg/Tcg2Smm/Tpm.asl > index 776f43e..37012bd 100644 > --- a/SecurityPkg/Tcg/Tcg2Smm/Tpm.asl > +++ b/SecurityPkg/Tcg/Tcg2Smm/Tpm.asl > @@ -3,6 +3,7 @@ > and MemoryClear. > > Copyright (c) 2015, Intel Corporation. All rights reserved.<BR> > +(c) Copyright 2016 HP Development Company, L.P.<BR> > This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD > License > which accompanies this distribution. The full text of the license may be > found at > @@ -40,7 +41,7 @@ DefinitionBlock ( > // Return the resource consumed by TPM device > // > Name (_CRS, ResourceTemplate () { > - Memory32Fixed (ReadOnly, 0xfed40000, 0x5000) > + Memory32Fixed (ReadWrite, 0xfed40000, 0x5000) > }) > > // > -- > 2.7.1.windows.1 > > _______________________________________________ > edk2-devel mailing list > [email protected] > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
