On 03/04/16 10:31, Ni, Ruiyu wrote: > Laszlo, > > Thank you for committing patches for meJ.
Sure -- I gladly help committing stuff outside of OvmfPkg too, especially if I'm reviewing and/or testing the patch anyway. Thanks! Laszlo > > > > Regards, > > Ray > > > > *From:*Laszlo Ersek [mailto:ler...@redhat.com] > *Sent:* Friday, March 4, 2016 5:12 PM > *To:* Ni, Ruiyu <ruiyu...@intel.com> > *Cc:* edk2-de...@ml01.01.org; Yao, Jiewen <jiewen....@intel.com> > *Subject:* Re: [edk2] [Patch] MdeModulePkg/PciHostBridge: Don't assert > when setting UC to MMIO fails > > > > On 03/04/16 06:04, Ruiyu Ni wrote: >> Failing to set EFI_MEMORY_UC to MMIO aperture is not a fatal error. > > Particularly on a 32-bit processor that doesn't support MTRR ;) > > Reviewed-by: Laszlo Ersek <ler...@redhat.com <mailto:ler...@redhat.com>> > Tested-by: Laszlo Ersek <ler...@redhat.com <mailto:ler...@redhat.com>> > > Committed as git 13be90faafdf. > > Thanks > Laszlo > >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ruiyu Ni <ruiyu...@intel.com <mailto:ruiyu...@intel.com>> >> Cc: Jiewen Yao <jiewen....@intel.com <mailto:jiewen....@intel.com>> >> --- >> MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c >> b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c >> index ef0c4f2..d5da699 100644 >> --- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c >> +++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c >> @@ -425,7 +425,9 @@ InitializePciHostBridge ( >> MemApertures[MemApertureIndex]->Limit - >> MemApertures[MemApertureIndex]->Base + 1, >> EFI_MEMORY_UC >> ); >> - ASSERT_EFI_ERROR (Status); >> + if (EFI_ERROR (Status)) { >> + DEBUG ((DEBUG_WARN, "PciHostBridge driver failed to set >> EFI_MEMORY_UC to MMIO aperture - %r.\n", Status)); >> + } >> } >> } >> // >> > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
