From: Sami Mujawar <sami.muja...@arm.com> The Reserved field in the SBSA Generic Watchdog Structure is 1 byte in length. Refer Table 5-123 in the ACPI 5.1 Specification Errata A.
The EFI_ACPI_5_1_SBSA_GENERIC_WATCHDOG_STRUCTURE_INIT() helper macro was initializing this field as EFI_ACPI_RESERVED_WORD instead of EFI_ACPI_RESERVED_BYTE. Although this does not cause any functional issue; it does not comply with the specification. Code at: https://github.com/EvanLloyd/tianocore/commit/654d129c3994761131476278e9b4ad04dfc13f27 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Alexei Fedorov <alexei.fedo...@arm.com> Signed-off-by: Girish Pathak <girish.pat...@arm.com> Signed-off-by: Sami Mujawar <sami.muja...@arm.com> Signed-off-by: Evan Lloyd <evan.ll...@arm.com> --- EmbeddedPkg/Include/Library/AcpiLib.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/EmbeddedPkg/Include/Library/AcpiLib.h b/EmbeddedPkg/Include/Library/AcpiLib.h index 42710fd..74a929c 100644 --- a/EmbeddedPkg/Include/Library/AcpiLib.h +++ b/EmbeddedPkg/Include/Library/AcpiLib.h @@ -1,7 +1,7 @@ /** @file Helper Library for ACPI - Copyright (c) 2014-2015, ARM Ltd. All rights reserved. + Copyright (c) 2014-2016, ARM Ltd. All rights reserved. This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License @@ -67,7 +67,7 @@ ControlFramePhysicalAddress, WatchdogTimerGSIV, WatchdogTimerFlags) \ { \ EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG, sizeof(EFI_ACPI_5_1_GTDT_SBSA_GENERIC_WATCHDOG_STRUCTURE), \ - EFI_ACPI_RESERVED_WORD, RefreshFramePhysicalAddress, ControlFramePhysicalAddress, \ + EFI_ACPI_RESERVED_BYTE, RefreshFramePhysicalAddress, ControlFramePhysicalAddress, \ WatchdogTimerGSIV, WatchdogTimerFlags \ } -- 2.7.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
