HI Sami Your update seems good to me. I checked spec and found more fields missing. Can we also add ARM DCC and BCM 2835, to make it complete?
0x000d (deprecated) ARM SBSA (2.x only) Generic UART supporting only 32-bit accesses 0x000e ARM SBSA Generic UART 0x000f ARM DCC 0x0010 BCM2835 Thank you Yao Jiewen -----Original Message----- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of evan.ll...@arm.com Sent: Friday, March 04, 2016 10:59 PM To: edk2-de...@ml01.01.org; Kinney, Michael D; Gao, Liming Cc: leif.lindh...@linaro.org Subject: [edk2] [PATCH 2/2] MdePkg: Add ARM Serial Port Subtypes to DBG2 From: Sami Mujawar <sami.muja...@arm.com> The Microsoft Debug Port Table 2 (DBG2) specification revision October 6, 2015 adds support for Serial Port Subtypes for ARM. This patch adds these definitions. Code at: https://github.com/EvanLloyd/tianocore/commit/8635af07ca47b803bc97060a5e6ab17be4e1f2f7 Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Alexei Fedorov <alexei.fedo...@arm.com> Signed-off-by: Girish Pathak <girish.pat...@arm.com> Signed-off-by: Sami Mujawar <sami.muja...@arm.com> Signed-off-by: Evan Lloyd <evan.ll...@arm.com> --- MdePkg/Include/IndustryStandard/DebugPort2Table.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/MdePkg/Include/IndustryStandard/DebugPort2Table.h b/MdePkg/Include/IndustryStandard/DebugPort2Table.h index 4014c9f..4595789 100644 --- a/MdePkg/Include/IndustryStandard/DebugPort2Table.h +++ b/MdePkg/Include/IndustryStandard/DebugPort2Table.h @@ -3,6 +3,7 @@ Microsoft DebugPort2Specification. Copyright (c) 2012, Intel Corporation. All rights reserved.<BR> + Copyright (c) 2012 - 2016, ARM Limited. All rights reserved.<BR> This program and the accompanying materials are licensed and made available under the terms and conditions of the BSD License which accompanies this distribution. The full text of the license may be found at @@ -47,6 +48,9 @@ typedef struct { #define EFI_ACPI_DBG2_PORT_TYPE_SERIAL 0x8000 #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_FULL_16550 0x0000 #define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_SUBSET_COMPATIBLE_WITH_MS_DBGP_SPEC 0x0001 +#define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_PL011_UART 0x0003 +#define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART_2X 0x000d +#define EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_ARM_SBSA_GENERIC_UART 0x000e #define EFI_ACPI_DBG2_PORT_TYPE_1394 0x8001 #define EFI_ACPI_DBG2_PORT_SUBTYPE_1394_STANDARD 0x0000 #define EFI_ACPI_DBG2_PORT_TYPE_USB 0x8002 -- 2.7.0 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
