Andrew: Now, Build tool will report error message if Conf directory or build configuration file is not found. It can detect the wrong setting when user specifies Conf by mistake.
Thanks Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Andrew Fish > Sent: Saturday, March 05, 2016 2:51 AM > To: Leahy, Leroy P > Cc: Justen, Jordan L; edk2-devel@lists.01.org; Bjorge, Erik C > Subject: Re: [edk2] [PATCH 1/9] edksetup.sh: Create the Conf directory if > necessary > > > > On Mar 4, 2016, at 8:54 AM, Lee Leahy <leroy.p.le...@intel.com> wrote: > > > > Edit the shell script to determine if the Conf directory is present. If > > not then create the Conf directory. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Lee Leahy <leroy.p.le...@intel.com> > > --- > > edksetup.sh | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/edksetup.sh b/edksetup.sh > > index 57368b5..d89ef9d 100755 > > --- a/edksetup.sh > > +++ b/edksetup.sh > > @@ -72,6 +72,10 @@ function SetWorkspace() > > > > function SetupEnv() > > { > > + if [ ! -d "$WORKSPACE/Conf" ] > > + then > > + mkdir $WORKSPACE/Conf > > + fi > > This comment is not related to this patch..... > > What is the process to propose a change to the edk2 build specification? > > I think the creation of Conf/ if it does not exist should be moved to build.py > (build.exe). The copy of the *.template files to Conf/*.txt could also be > moved into build.py. > > The reason I advocate this is we have started using the build -- > conf=CONFDIRECTORY flag, and we point CONFDIRECTORY to the build > output directory. This enables building different platforms in parallel. It > also > makes it possible to write a top level GNUmakefile and not have to call any > shell scripts to build. Basically the top level makefile can do a `export > WORKSPACE, export EDK_TOOLS_PATH, export PATH` and it is possible to > avoid calling any scripts to setup the environment. > > Thus moving the Conf/ processing to build.py (build.exe) makes it more > convenient to use the --conf flag, and helps make the setup scripts less > complex. > > Thanks, > > Andrew Fish > > > > if [ -n "$EDK_TOOLS_PATH" ] > > then > > . $EDK_TOOLS_PATH/BuildEnv $* > > -- > > 1.9.1 > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
