Reviewed-by: Ruiyu Ni <ruiyu...@intel.com>



-----Original Message-----
From: Bjorge, Erik C
Sent: Friday, March 4, 2016 10:01 AM
To: Leahy, Leroy P <leroy.p.le...@intel.com<mailto:leroy.p.le...@intel.com>>; 
Ni, Ruiyu <ruiyu...@intel.com<mailto:ruiyu...@intel.com>>; 
edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
Subject: RE: [PATCH 4/9] DuetPkg/PciBusNoEnumerationDxe: Skip disabled devices

Reviewed-by: Erik Bjorge 
<erik.c.bjo...@intel.com<mailto:erik.c.bjo...@intel.com>>

> -----Original Message-----
> From: Leahy, Leroy P
> Sent: Friday, March 4, 2016 8:59 AM
> To: Ni, Ruiyu <ruiyu...@intel.com<mailto:ruiyu...@intel.com>>; 
> edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>; Bjorge,
> Erik C <erik.c.bjo...@intel.com<mailto:erik.c.bjo...@intel.com>>
> Cc: Leahy, Leroy P <leroy.p.le...@intel.com<mailto:leroy.p.le...@intel.com>>
> Subject: [PATCH 4/9] DuetPkg/PciBusNoEnumerationDxe: Skip disabled
> devices
>
> Skip non-bridge devices which are not enabled either for memory or I/O
> access.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Lee Leahy 
> <leroy.p.le...@intel.com<mailto:leroy.p.le...@intel.com>>
> ---
>  DuetPkg/PciBusNoEnumerationDxe/PciEnumeratorSupport.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/DuetPkg/PciBusNoEnumerationDxe/PciEnumeratorSupport.c
> b/DuetPkg/PciBusNoEnumerationDxe/PciEnumeratorSupport.c
> index ca300cf..3802424 100644
> --- a/DuetPkg/PciBusNoEnumerationDxe/PciEnumeratorSupport.c
> +++ b/DuetPkg/PciBusNoEnumerationDxe/PciEnumeratorSupport.c
> @@ -227,6 +227,15 @@ Returns:
>        if (!EFI_ERROR (Status)) {
>
>          //
> +        // Skip non-bridge devices which are not enabled
> +        //
> +        if (((Pci.Hdr.Command & (EFI_PCI_COMMAND_IO_SPACE
> +                                  | EFI_PCI_COMMAND_MEMORY_SPACE)) ==
> 0)
> +          && (!(IS_PCI_BRIDGE (&Pci) || IS_CARDBUS_BRIDGE (&Pci)))) {
> +          continue;
> +        }
> +
> +        //
>          // Collect all the information about the PCI device discovered
>          //
>          Status = PciSearchDevice (
> --
> 1.9.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to