Hi Liming, Thank you for the information, the flag will be handled within OpenPlatformPkg then.
Best regards, Marcin 2016-03-17 14:49 GMT+01:00 Gao, Liming <liming....@intel.com>: > Bartosz: > > MdePkg definition conforms to UEFI/PI and Industry specification. If it is > not in spec, it will not be added into MdePkg. For this case, it can locally > be added into OpenPlatformPkg. If you think it is valuable to be in PI spec, > you can contribute PI spec mantis to uefi.org. > > > > Thanks > > Liming > > From: Bartosz Szczepanek [mailto:b...@semihalf.com] > Sent: Thursday, March 17, 2016 6:55 PM > To: Gao, Liming <liming....@intel.com> > Cc: Marcin Wojtas <m...@semihalf.com>; edk2-devel@lists.01.org; > ha...@marvell.com; leif.lindh...@linaro.org; n...@marvell.com; Kinney, > Michael D <michael.d.kin...@intel.com> > Subject: Re: [edk2] [PATCH] MdePkg: Add NORESTART flag to I2C header > > > > Hello Liming, > > indeed it's not in PI specification. This flag was introduced in order > to ease development of EEPROM drivers, as these devices expect no > repeated start condition in write operation. It's neither vendor nor > platform specific, so we didn't stick that to our platform package. Do > you think it's possible to amend the specification, or should we add > the flag locally in OpenPlatformPkg? > > Best regards, > Bartosz > > 2016-03-17 2:33 GMT+01:00 Gao, Liming : >> I don't find I2C_FLAG_NORESTART definition in PI spec 1.4. Where is to get >> it? >> >> Thanks >> Liming >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of >> Marcin Wojtas >> Sent: Wednesday, March 16, 2016 11:33 PM >> To: edk2-devel@lists.01.org >> Cc: ha...@marvell.com; leif.lindh...@linaro.org; b...@semihalf.com; >> n...@marvell.com; Gao, Liming ; Kinney, Michael D >> Subject: [edk2] [PATCH] MdePkg: Add NORESTART flag to I2C header >> >> From: Bartosz Szczepanek >> >> I2C_NORESTART_FLAG allows to continue transmission without repeated >> start operation. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Bartosz Szczepanek >> --- >> MdePkg/Include/Pi/PiI2c.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/MdePkg/Include/Pi/PiI2c.h b/MdePkg/Include/Pi/PiI2c.h >> index d7e0e2d..2c941cb 100644 >> --- a/MdePkg/Include/Pi/PiI2c.h >> +++ b/MdePkg/Include/Pi/PiI2c.h >> @@ -112,6 +112,7 @@ typedef struct { >> /// >> /// I2C read operation when set >> #define I2C_FLAG_READ 0x00000001 >> +#define I2C_FLAG_NORESTART 0x00000002 >> >> /// >> /// Define the flags for SMBus operation >> -- >> 1.8.3.1 >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
