Hi Jordan, On Mon, Mar 21, 2016 at 8:24 PM, Jordan Justen <jordan.l.jus...@intel.com> wrote: > On 2016-03-21 01:02:53, Laszlo Ersek wrote: >> On 03/20/16 17:58, Paulo Alcantara wrote: >> > This patch adds RamDiskDxe driver to OVMF through a new introduced flag >> > "RAMDISK_SUPPORT_ENABLE" which is disabled by default and may be enabled >> > with -DRAMDISK_SUPPORT_ENABLE=TRUE at build time. >> > >> > Cc: Jordan Justen <jordan.l.jus...@intel.com> >> > Cc: Laszlo Ersek <ler...@redhat.com> >> > Contributed-under: TianoCore Contribution Agreement 1.0 >> > Signed-off-by: Paulo Alcantara <paulo.alc.cavalca...@hp.com> >> > --- >> > OvmfPkg/OvmfPkgIa32.dsc | 6 +++++- >> > OvmfPkg/OvmfPkgIa32.fdf | 3 +++ >> > OvmfPkg/OvmfPkgIa32X64.dsc | 4 ++++ >> > OvmfPkg/OvmfPkgIa32X64.fdf | 3 +++ >> > OvmfPkg/OvmfPkgX64.dsc | 6 +++++- >> > OvmfPkg/OvmfPkgX64.fdf | 3 +++ >> > 6 files changed, 23 insertions(+), 2 deletions(-) >> >> I think it should be fine to enable this unconditionally. Jordan, what >> do you think? >> > > So, this driver won't really take much action until the setup browser > is used to configure a ram disk? > > If so, it seems reasonable to include it by default. > > Does the setup browser actually have support for EFI_RAM_DISK_PROTOCOL > yet? (git grep EFI_RAM_DISK_PROTOCOL is a bit sparse)
I actually don't know whether the setup browser supports it or not, but the RAM disk support is useful in many contexts -- either it's being used by an application or driver. I added a flag to it because it seems like an optional feature to me rather than something required to boot a platform. Yet, it's working perfectly fine and solving my problems :-) Paulo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
