On 24 March 2016 at 09:11, Laszlo Ersek <ler...@redhat.com> wrote: > On 03/24/16 07:45, Ard Biesheuvel wrote: >> On 24 March 2016 at 07:41, Gao, Liming <liming....@intel.com> wrote: >>> Ard: >>> Thanks for your contribution. I agree to enable this warning in DEBUG >>> only. Reviewed-by: Liming Gao <liming....@intel.com> for this serials. >>> >> >> Thanks Liming. >> >> I will hold off from merging most of these patches to allow for some >> more discussion (and I'd like Laszlo's take on this as well), but in >> the mean time, I will go ahead and commit patch #2 since it fixes the >> currently broken build on ARM and AARCH64. > > I agree that you should commit patch #2. Please do that. > > Other than that, how about this: I will pick up your patches #1, #3, and > #4, with Liming's and my own R-b's, and then I'll rebase (and continue) > my cleanup patches on top. Deal? >
Deal! > I think it's an awesome idea that we enable the warning for DEBUG builds > only, where MDEPKG_NDEBUG should always be absent. > > ... Hm, there seems to be one platform that is an exception, > Vlv2TbltDevicePkg/*.dsc, but I'll fix up those DSCs as well. > Thanks, Ard. _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
