On 2016-04-05 10:46:15, Andrew Fish wrote: > > > On Apr 5, 2016, at 10:26 AM, Jordan Justen <jordan.l.jus...@intel.com> > > wrote: > > > > I don't think it conflicts either. > > > > I wonder if Mike or Andrew have any thoughts about why the ACPI > > includes (and arguably EDK II) go out of their way to define flattened > > (duplicated) structures for different spec versions. > > > > Once again, I personally don't mind the sub-structure based on > > versions if Mike and Andrew don't have anything to add... > > Jordan, > > I'm not sure why things like GENERIC_ADDRESS_STRUCTURE keep getting > redefined even though the definition > EFI_ACPI_5_0_GENERIC_ADDRESS_STRUCTURE is the same as > EFI_ACPI_5_0_GENERIC_ADDRESS_STRUCTURE. Some things are actually > different, for example EFI_ACPI_5_0_FIXED_ACPI_DESCRIPTION_TABLE has > more entries than EFI_ACPI_4_0_FIXED_ACPI_DESCRIPTION_TABLE. > > Maybe Mike remembers the reason? > > Seems like changing it now risks breaking existing code. >
Yeah. I'm not interested in changing the ACPI definitions, but I'm wondering if it sets a precedent for EDK II style or not. Unless Mike has something to add, I guess the answer to that is 'no'. Thanks, -Jordan _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
