Hello Liming, Yeah, I didn't quite think the MODULE_DIR comment through, you are definitely right about that. Though it would be nice to fix PLATFORM_DIR nevertheless (it still is $(WORKSPACE)\AnyPkg, even though it is in a PACKAGES_PATH folder), so Makefiles etc. can use it to build their own paths relative to the platform directory. I just checked a new Makefile and all other paths seem to be correct by now.
Regards, Marvin. ________________________________________ Von: Gao, Liming <liming....@intel.com> Gesendet: Montag, 11. April 2016 16:05 An: marvin.haeu...@outlook.com; edk2-devel@lists.01.org Betreff: RE: [edk2] BaseTools: Refinded Multiple Workspaces support. Marvin: Sorry. I miss this mail. I agree to fix PLATFORM_DIR variable value. But, PLATFORM_DIR variable points to the package that places platform DSC file. The built module may be from the different packages. So, PLATFORM_DIR can't be used to construct MODULE_DIR. After multiple workspaces are supported, there will not be root directory to include all built module INF files. So, there is no such central variable. Thanks Liming -----Original Message----- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Marvin H?user Sent: Saturday, April 9, 2016 3:42 AM To: edk2-devel@lists.01.org Subject: Re: [edk2] BaseTools: Refinded Multiple Workspaces support. Dear developers, I do not want to clutter your inboxes, but there has not been any reply to this idea from Februrary. Even though I lack any kind of Python skill and BaseTools knowledge, as mentioned in the original E-Mail, I would try to work on it when I can (please do not rely on me though, in case you see such a change as necessary). Using PLATFORM_DIR in Makefiles would, in my opinion, make the Multiple Workspaces concept way better, as currently the project I am contributing to uses the WORKSPACE variable, as no other variable provided by EDK2 can be relied on when MWS is in use. I appreciate any kind of feedback. Best regards, Marvin. ________________________________________ Von: edk2-devel <edk2-devel-boun...@lists.01.org> im Auftrag von Marvin Häuser <marvin.haeu...@outlook.com> Gesendet: Sonntag, 21. Februar 2016 02:00 An: edk2-devel@lists.01.org Betreff: [edk2] BaseTools: Refinded Multiple Workspaces support. Dear edk2-devel subscribers, A few moments ago, I have published a patch to the EDK2 BaseTools with the subject "BaseTools: Add Multiple Workspaces support for custom Makefiles.", which is aimed at providing Custom Makefile modules support for Multiple Workspaces. Writing the patch, I noticed that in quite a few areas WORKSPACE is still used (especially in MODULE_DIR, which is the reason custom Makefile modules would not be buildable in a different workspace from the primary). In the places in which it isn't, mws.join() is called to construct a path by also checking the PACKAGES_PATH list. To simplify the process and ending with cleaner code, I propose to have the PLATFORM_DIR variable fixed to point to the correct, absolute path and construct other variables (such as MODULE_DIR) from that value, so PLATFORM_DIR serves as a central variable (changes to it affect all paths = easier to maintain). Sadly, I do not think I either have the Python skills, or the insight in the inner workings of BaseTools to implement such a patch. I would be grateful if someone would look into implementing this, or a similar behavior to fully support Multiple Workspaces and have an easier to maintain codebase. Regards, Marvin. _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
