Gary, No, anyway the device path must be updated to reflect the correct IP and URI setting for the current HTTP boot. I only explained why the corporation boot option is also updated, because it's just an auto enumerated boot option by BDS.
Best Regards Siyuan From: Li, Gary (HPS SW) [mailto:gar...@hpe.com] Sent: Monday, April 25, 2016 11:41 AM To: Fu, Siyuan <siyuan...@intel.com>; El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com>; edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com>; Li, Gary (HPS SW) <gar...@hpe.com> Subject: RE: [PATCH] NetworkPkg: Don't need to update device path in home environment Hi Siyuan, So, this change is OK to commit, right? Regards, Gary Li Platform SW Engineering Servers Office: +886 (2) 8722 9977 -----Original Message----- From: Fu, Siyuan [mailto:siyuan...@intel.com] Sent: Monday, April 25, 2016 8:48 AM To: El-Haj-Mahmoud, Samer <samer.el-haj-mahm...@hpe.com<mailto:samer.el-haj-mahm...@hpe.com>>; Li, Gary (HPS SW) <gar...@hpe.com<mailto:gar...@hpe.com>>; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> Cc: Ye, Ting <ting...@intel.com<mailto:ting...@intel.com>>; Wu, Jiaxin <jiaxin...@intel.com<mailto:jiaxin...@intel.com>> Subject: RE: [PATCH] NetworkPkg: Don't need to update device path in home environment Already replied, see attached mail. > -----Original Message----- > From: El-Haj-Mahmoud, Samer [mailto:samer.el-haj-mahm...@hpe.com] > Sent: Friday, April 22, 2016 11:07 PM > To: Li, Gary (HPS SW) <gar...@hpe.com<mailto:gar...@hpe.com>>; > edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> > Cc: Ye, Ting <ting...@intel.com<mailto:ting...@intel.com>>; Fu, Siyuan > <siyuan...@intel.com<mailto:siyuan...@intel.com>>; > Wu, Jiaxin <jiaxin...@intel.com<mailto:jiaxin...@intel.com>>; El-Haj-Mahmoud, > Samer <samer.el-haj- > mahm...@hpe.com<mailto:mahm...@hpe.com>> > Subject: RE: [PATCH] NetworkPkg: Don't need to update device path in > home environment > > Ting, Siyuan, Jiaxin, > > Can one of you please commit this change if you have no objections? > > Thanks, > --Samer > > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > El- Haj-Mahmoud, Samer > Sent: Friday, April 15, 2016 8:26 AM > To: Li, Gary (HPS SW) <gar...@hpe.com<mailto:gar...@hpe.com>>; > edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> > Cc: ting...@intel.com<mailto:ting...@intel.com>; > siyuan...@intel.com<mailto:siyuan...@intel.com>; > jiaxin...@intel.com<mailto:jiaxin...@intel.com> > Subject: Re: [edk2] [PATCH] NetworkPkg: Don't need to update device > path in home environment > > Reviewed-by: Samer El-Haj-Mahmoud <el...@hpe.com<mailto:el...@hpe.com>> > > -----Original Message----- > From: Li, Gary (HPS SW) > Sent: Thursday, April 14, 2016 10:32 PM > To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> > Cc: El-Haj-Mahmoud, Samer > <samer.el-haj-mahm...@hpe.com<mailto:samer.el-haj-mahm...@hpe.com>>; > siyuan...@intel.com<mailto:siyuan...@intel.com>; > jiaxin...@intel.com<mailto:jiaxin...@intel.com>; > ting...@intel.com<mailto:ting...@intel.com>; Li, Gary > (HPS > SW) <gar...@hpe.com<mailto:gar...@hpe.com>> > Subject: [PATCH] NetworkPkg: Don't need to update device path in home > environment > > Don't need to update device path in home environment > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Gary Li <gar...@hpe.com<mailto:gar...@hpe.com>> > --- > NetworkPkg/HttpBootDxe/HttpBootClient.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/NetworkPkg/HttpBootDxe/HttpBootClient.c > b/NetworkPkg/HttpBootDxe/HttpBootClient.c > index 9d445e3..7c28009 100644 > --- a/NetworkPkg/HttpBootDxe/HttpBootClient.c > +++ b/NetworkPkg/HttpBootDxe/HttpBootClient.c > @@ -36,6 +36,13 @@ HttpBootUpdateDevicePath ( > UINTN Length; > EFI_STATUS Status; > > + // > + // Don't need to update device path in home environment // if > + (Private->FilePathUri != NULL) { > + return EFI_SUCCESS; > + } > + > TmpDevicePath = NULL; > > // > -- > 2.7.2.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
