Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -----Original Message----- > From: Shia, Cinnamon [mailto:cinnamon.s...@hpe.com] > Sent: Monday, May 02, 2016 2:23 AM > To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org > Cc: Carsey, Jaben <jaben.car...@intel.com>; Gao, Liming > <liming....@intel.com> > Subject: RE: [PATCH] PerformancePkg Dp_App: Delete InitCumulativeData() > Importance: High > > Thanks for fixing it. > > Reviewed-by: Cinnamon Shia <cinnamon.s...@hpe.com> > > -----Original Message----- > From: Star Zeng [mailto:star.z...@intel.com] > Sent: Monday, May 2, 2016 4:51 PM > To: edk2-devel@lists.01.org > Cc: Shia, Cinnamon <cinnamon.s...@hpe.com>; Jaben Carsey > <jaben.car...@intel.com>; Liming Gao <liming....@intel.com> > Subject: [PATCH] PerformancePkg Dp_App: Delete InitCumulativeData() > > InitCumulativeData is introduced by > d28f77df0f51f84b0af79f09abe2c27b1f1aaa69, > it is needed by ShellPkg UefiDpLib, but not needed by PerformancePkg > Dp_App. > > This patch is to delete it. > > Cc: Cinnamon Shia <cinnamon.s...@hpe.com> > Cc: Jaben Carsey <jaben.car...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Star Zeng <star.z...@intel.com> > --- > PerformancePkg/Dp_App/Dp.c | 19 ------------------- > 1 file changed, 19 deletions(-) > > diff --git a/PerformancePkg/Dp_App/Dp.c b/PerformancePkg/Dp_App/Dp.c > index 283b61ccd4e0..6d980e5c55dc 100644 > --- a/PerformancePkg/Dp_App/Dp.c > +++ b/PerformancePkg/Dp_App/Dp.c > @@ -184,25 +184,6 @@ DumpStatistics( void ) } > > /** > - Initialize the cumulative data. > - > -**/ > -VOID > -InitCumulativeData ( > - VOID > - ) > -{ > - UINTN Index; > - > - for (Index = 0; Index < NumCum; ++Index) { > - CumData[Index].Count = 0; > - CumData[Index].MinDur = PERF_MAXDUR; > - CumData[Index].MaxDur = 0; > - CumData[Index].Duration = 0; > - } > -} > - > -/** > Dump performance data. > > @param[in] ImageHandle The image handle. > -- > 2.8.1.windows.1 >
_______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
