Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -----Original Message----- > From: Zeng, Star > Sent: Monday, May 02, 2016 1:25 AM > To: Cinnamon Shia <cinnamon.s...@hpe.com>; edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Carsey, Jaben > <jaben.car...@intel.com>; samer.el-haj-mahm...@hpe.com > Subject: RE: [PATCH v3 1/2] ShellPkg/UefiDpLib: Fix the error message "Timer > library instance error!" > Importance: High > > Reviewed-by: Star Zeng <star.z...@intel.com> to series. > > Thanks, > Star > -----Original Message----- > From: Cinnamon Shia [mailto:cinnamon.s...@hpe.com] > Sent: Monday, May 2, 2016 12:34 PM > To: edk2-devel@lists.01.org > Cc: Qiu, Shumin <shumin....@intel.com>; Zeng, Star <star.z...@intel.com>; > Carsey, Jaben <jaben.car...@intel.com>; samer.el-haj-mahm...@hpe.com; > Cinnamon Shia <cinnamon.s...@hpe.com> > Subject: [PATCH v3 1/2] ShellPkg/UefiDpLib: Fix the error message "Timer > library instance error!" > > When executing shell dp command, there is an error message "Timer library > instance error!" > > The error message "Timer library instance error!" should be for the case > about duration > EndTimeStamp if CountUp or duration > StartTimeStamp if > CountDown. > > But if the EndTimeStamp of an entry is not added, it should not the case to > catch. > > This change fixes the error message "Timer library instance error!" from the > "BdsAttempt" entry which is logged when trying to boot a boot option. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Cinnamon Shia <cinnamon.s...@hpe.com> > --- > ShellPkg/Library/UefiDpLib/DpUtilities.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/ShellPkg/Library/UefiDpLib/DpUtilities.c > b/ShellPkg/Library/UefiDpLib/DpUtilities.c > index 032e7b4..fbdd938 100644 > --- a/ShellPkg/Library/UefiDpLib/DpUtilities.c > +++ b/ShellPkg/Library/UefiDpLib/DpUtilities.c > @@ -2,7 +2,7 @@ > Utility functions used by the Dp application. > > Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved. > - (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR> > + (C) Copyright 2015-2016 Hewlett Packard Enterprise Development LP<BR> > This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD > License > which accompanies this distribution. The full text of the license may be > found at @@ -68,6 +68,10 @@ GetDuration ( > UINT64 Duration; > BOOLEAN Error; > > + if (Measurement->EndTimeStamp == 0) { > + return 0; > + } > + > // PERF_START macros are called with a value of 1 to indicate > // the beginning of time. So, adjust the start ticker value > // to the real beginning of time. > -- > 2.8.1.windows.1
_______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
