Hi, Darbin As you know, we take extra caution on interface changes. We expect it's stable enough.
So I have the below questions: 1. I only see the NVME_ADMIN cmds are added, could you add NVME_IO cmds to Nvme.h as well? 2. Shall we be compliance with NVMe 1.2 spec to add missing cmds? 3. what's the role to introduce such NvmExpressLib library class? For example, why only Get Log/ Identify/ firmware download and activate APIs are added? Do we need add other cmd's wrapper to this new library? Do we need put it in MdeModulePkg or MdePkg? Thanks Feng -----Original Message----- From: [email protected] [mailto:[email protected]] Sent: Thursday, May 12, 2016 6:59 AM To: [email protected] Cc: Tian, Feng <[email protected]>; Zeng, Star <[email protected]>; Kinney, Michael D <[email protected]>; Gao, Liming <[email protected]>; [email protected]; Darbin Reyes <[email protected]> Subject: [PATCH 0/3] *** Add Nvme.h and NvmExpressLib *** From: Darbin Reyes <[email protected]> *** Add Nvme.h and NvmExpressLib *** Darbin Reyes (3): MdePkg: Add a header for NVMe v1.1 spec. definitions. MdeModulePkg: Move/Replace NvmExpressHci.h definitions to Nvme.h. MdeModulePkg: Add NvmExpressLib. MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpress.h | 2 + MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressHci.h | 389 +------------ MdeModulePkg/Include/Library/NvmExpressLib.h | 279 +++++++++ .../Library/DxeNvmExpressLib/DxeNvmExpressLib.c | 637 +++++++++++++++++++++ .../Library/DxeNvmExpressLib/DxeNvmExpressLib.inf | 41 ++ MdeModulePkg/MdeModulePkg.dec | 4 + MdePkg/Include/IndustryStandard/Nvme.h | 603 +++++++++++++++++++ 7 files changed, 1568 insertions(+), 387 deletions(-) create mode 100644 MdeModulePkg/Include/Library/NvmExpressLib.h create mode 100644 MdeModulePkg/Library/DxeNvmExpressLib/DxeNvmExpressLib.c create mode 100644 MdeModulePkg/Library/DxeNvmExpressLib/DxeNvmExpressLib.inf create mode 100644 MdePkg/Include/IndustryStandard/Nvme.h -- 1.7.11.msysgit.1 _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
