Hi Mike,

This was the specific request from the CorebootPayloadPkg maintainers.  The 
first version of the patch copied the code into CorebootModulePkg to eliminate 
this require dependency.

Lee Leahy
(425) 881-4919
Intel Corporation
Suite 125
2700 - 156th Ave NE
Bellevue, WA 98007-6554

-----Original Message-----
From: Kinney, Michael D 
Sent: Thursday, May 12, 2016 4:12 PM
To: Leahy, Leroy P <[email protected]>; [email protected]; Leahy, 
Leroy P <[email protected]>; [email protected]; Agyeman, Prince 
<[email protected]>; Ma, Maurice <[email protected]>; El-Haj-Mahmoud, 
Samer <[email protected]>; Kinney, Michael D 
<[email protected]>
Subject: RE: [edk2] [PATCH] CorebootPayloadPkg: Add OHCI driver

Hi Lee,

It seems strange for the CorebootPayloadPkg to depend on the QuarkPlatformPkg.

There is a request to add OHCI to MdeModulePkg.

        http://article.gmane.org/gmane.comp.bios.edk2.devel/7536/match=ohci

Maybe Samer has some updates on testing.  

Thanks,

Mike

> -----Original Message-----
> From: edk2-devel [mailto:[email protected]] On Behalf Of 
> Lee Leahy
> Sent: Thursday, May 12, 2016 4:05 PM
> To: [email protected]; Leahy, Leroy P <[email protected]>; 
> [email protected]; Agyeman, Prince <[email protected]>; Ma, 
> Maurice <[email protected]>
> Subject: [edk2] [PATCH] CorebootPayloadPkg: Add OHCI driver
> 
> Add the USB OHCI driver from revision 24ca2f35 of QuarkSocPkg.
> 
> Change-Id: Ie7aa0bc47d4ff06adc57976a5efb0e40ce4e1673
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Lee Leahy <[email protected]>
> ---
>  CorebootPayloadPkg/CorebootPayloadPkg.fdf        | 5 +++++
>  CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc    | 5 +++++
>  CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 5 +++++
>  3 files changed, 15 insertions(+)
> 
> diff --git a/CorebootPayloadPkg/CorebootPayloadPkg.fdf
> b/CorebootPayloadPkg/CorebootPayloadPkg.fdf
> index 4102e60..0e8ec43 100644
> --- a/CorebootPayloadPkg/CorebootPayloadPkg.fdf
> +++ b/CorebootPayloadPkg/CorebootPayloadPkg.fdf
> @@ -159,6 +159,11 @@ INF MdeModulePkg/Bus/Usb/UsbKbDxe/UsbKbDxe.inf
>  INF MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf
> 
>  #
> +# OHCI Support
> +#
> +INF QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Dxe/OhciDxe.inf
> +
> +#
>  # Shell
>  #
>  !if $(SHELL_TYPE) == BUILD_SHELL
> diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
> b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
> index 9f155f3..dc86eb1 100644
> --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
> +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
> @@ -431,6 +431,11 @@
>    MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf
> 
>    #
> +  # OHCI support
> +  #
> +  QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Dxe/OhciDxe.inf
> +
> +  #
>    # ISA Support
>    #
>    CorebootModulePkg/SerialDxe/SerialDxe.inf
> diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
> b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
> index 7b065a6..dabd2dd 100644
> --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
> +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
> @@ -435,6 +435,11 @@
>    MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf
> 
>    #
> +  # OHCI support
> +  #
> +  QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Dxe/OhciDxe.inf
> +
> +  #
>    # ISA Support
>    #
>    CorebootModulePkg/SerialDxe/SerialDxe.inf
> --
> 1.9.1
> 
> _______________________________________________
> edk2-devel mailing list
> [email protected]
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
[email protected]
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to