> On May 19, 2016, at 8:18 PM, Gao, Liming <liming....@intel.com> wrote:
> 
> Thanks Andrew. I will continue to investigate it. 
> 

>>> F = 'FileNoExtention'
>>> os.path.splitext(F)[1]
''
>>> '' in '.out'
True

So I think the bug is the `in` it should be `==`
>>> '' == '.out'
False

Thanks,

Andrew Fish


>> -----Original Message-----
>> From: af...@apple.com [mailto:af...@apple.com]
>> Sent: Friday, May 20, 2016 10:01 AM
>> To: Gao, Liming <liming....@intel.com>
>> Cc: edk2-devel <edk2-devel@lists.01.org>
>> Subject: Re: [edk2] [BaseTools] RuleOverride = BINARY code location?
>> 
>> 
>>> On May 18, 2016, at 5:44 PM, Andrew Fish <af...@apple.com> wrote:
>>> 
>>>> 
>>>> On May 18, 2016, at 5:43 PM, Gao, Liming <liming....@intel.com> wrote:
>>>> 
>>>> Andrew:
>>>> |.bin will search the file with the postfix .bin in INF file directory and 
>>>> its
>> output directory. So, there may be more than .bin files are found. Please see
>> the code login in GetFileList() from
>> C:\R9Tip\edk2\BaseTools\Source\Python\GenFds\Section.py.
>>>> 
>>> 
>> 
>> Thanks for the pointer.
>> 
>> This is the code that adding the OS executables in GetFileList() that is 
>> adding
>> the OS executables without the .bin extension.
>>            if os.path.exists(Makefile):
>>                # Update to search files with suffix in all sub-dirs.
>>                Tuple = os.walk(FfsInf.EfiOutputPath)
>>                for Dirpath, Dirnames, Filenames in Tuple:
>>                    for F in Filenames:
>>                        if os.path.splitext(F)[1] in (Suffix):
>>                            FullName = os.path.join(Dirpath, F)
>>                            if os.path.getmtime(FullName) > 
>> os.path.getmtime(Makefile):
>>                                FileList.append(FullName)
>> 
>> 
>> I think the issue is:
>>   if os.path.splitext(F)[1] in (Suffix):
>> 
>> If the file does not have an extension it matches.
>> 
>> Sorry might be wrong have to go out to a writers reading with my wife so
>> have to stop looking right now.
>> 
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> 
>> Thanks,
>> 
>> Andrew Fish
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to