Hao, HiiGetBrowserData() is only retrieving uncommitted data from the browser, so changed "size" value will not be stored into 'Configuration' until HiiSetBrowserData() is called at the end of the function.
Without this patch, I don't see 'size' value updated on a real HW system. Thanks, Tapan -----Original Message----- From: Wu, Hao A [mailto:hao.a...@intel.com] Sent: Thursday, June 02, 2016 9:18 PM To: Shah, Tapan <tapands...@hpe.com>; edk2-devel@lists.01.org Cc: Carsey, Jaben <jaben.car...@intel.com>; Tian, Feng <feng.t...@intel.com> Subject: RE: [edk2] [PATCH] MdeModulePkg/RamDiskDxe: Add RAW Ramdisk size change support in HII form Hi Tapan, Similar to the comments on your previous patch, I think a previous call to the function HiiGetBrowserData() already updates the content in 'Configuration'. So I think the origin code is fine, what's your thought? Best Regards Hao Wu > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Tapan Shah > Sent: Friday, June 03, 2016 2:35 AM > To: edk2-devel@lists.01.org > Cc: Carsey, Jaben; Wu, Hao A; Tian, Feng > Subject: [edk2] [PATCH] MdeModulePkg/RamDiskDxe: Add RAW Ramdisk size > change support in HII form > > Fix an issue where RAW disk size change was not stored back to the > variable store. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Tapan Shah <tapands...@hpe.com> > --- > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c > b/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c > index d8e081b..ad8af04 100644 > --- a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c > +++ b/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c > @@ -756,6 +756,11 @@ RamDiskCallback ( > *ActionRequest = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY; > break; > > + case CREATE_RAW_SIZE_QUESTION_ID: > + Configuration->Size = Value->u64; > + *ActionRequest = EFI_BROWSER_ACTION_REQUEST_FORM_APPLY; > + break; > + > default: > break; > } > -- > 2.6.2.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
