On 2016/6/7 0:45, Laszlo Ersek wrote:
On 06/06/16 12:38, Star Zeng wrote:
V2:
1. Fix typo in SmmLockBoxSmmConstructuor and SmmLockBoxSmmDestructuor.
2. Add comment for S3BootScriptLibDeinitialize to explain that the desturctor
doesn't
support unloading as a separate action, and it only supports unloading if the
containing driver's entry point function fails.
3. Revert git commit 058196bbb345.
Cc: Jiewen Yao <jiewen....@intel.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Star Zeng (4):
MdeModulePkg SmmLockBoxSmmLib: Fix typo in SmmLockBoxSmmConstructuor
MdeModulePkg SmmLockBoxSmmLib: Add DESTRUCTOR SmmLockBoxSmmDestructor
MdeModulePkg DxeS3BootScriptLib: Add DESTRUCTOR
S3BootScriptLibDeinitialize
MdeModulePkg DxeS3BootScriptLib: Revert git commit 058196bbb345
.../Library/PiDxeS3BootScriptLib/BootScriptSave.c | 159 ++++++++++++++++-----
.../PiDxeS3BootScriptLib/DxeS3BootScriptLib.inf | 4 +-
.../Library/SmmLockBoxLib/SmmLockBoxSmmLib.c | 49 ++++++-
.../Library/SmmLockBoxLib/SmmLockBoxSmmLib.inf | 5 +-
4 files changed, 171 insertions(+), 46 deletions(-)
I tested the series in the following scenarios:
- Ia32 build of OVMF, Q35, SMM_REQUIRE, S3 disabled and enabled
- Ia32X64 build of OVMF, Q35, SMM_REQUIRE, S3 disabled and enabled
- X64 build of OVMF, i440fx, S3 disabled and enabled
Everything seems to work fine. I can see the
S3BootScriptLibDeinitialize() message (from patch #3) in all three
S3-disabled cases, every time from two modules (S3SaveStateDxe and
BootScriptExecutorDxe).
Series
Tested-by: Laszlo Ersek <ler...@redhat.com>
Thanks!
Laszlo
Series pushed at da9d39c28ee24dde172616fe05ce3c252223b01c ..
626f6f6e74626a9d85d6c8ca2fa8473045580fcf.
Really appreciate the comments and tests.
Thanks,
Star
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
