Star, Thanks. I missed that behavior. I agree that ASSERT() is still in place.
Mike > -----Original Message----- > From: Zeng, Star > Sent: Thursday, June 16, 2016 5:31 PM > To: Kinney, Michael D <michael.d.kin...@intel.com>; edk2-devel@lists.01.org > Cc: Yao, Jiewen <jiewen....@intel.com>; Gao, Liming <liming....@intel.com>; > Dong, > Eric <eric.d...@intel.com>; Tian, Feng <feng.t...@intel.com>; Ni, Ruiyu > <ruiyu...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Wu, Jiaxin > <jiaxin...@intel.com>; Carsey, Jaben <jaben.car...@intel.com>; Zhang, Chao B > <chao.b.zh...@intel.com>; Fan, Jeff <jeff....@intel.com>; Zeng, Star > <star.z...@intel.com> > Subject: RE: [PATCH 0/8] Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr > > Mike, > > Good comments. > The new functions have below comments for the error return codes. > > If an error would be returned, then the function will also ASSERT(). > > > Thanks, > Star > -----Original Message----- > From: Kinney, Michael D > Sent: Friday, June 17, 2016 3:31 AM > To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org; Kinney, > Michael D > <michael.d.kin...@intel.com> > Cc: Yao, Jiewen <jiewen....@intel.com>; Gao, Liming <liming....@intel.com>; > Dong, > Eric <eric.d...@intel.com>; Tian, Feng <feng.t...@intel.com>; Ni, Ruiyu > <ruiyu...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Wu, Jiaxin > <jiaxin...@intel.com>; Carsey, Jaben <jaben.car...@intel.com>; Zhang, Chao B > <chao.b.zh...@intel.com>; Fan, Jeff <jeff....@intel.com> > Subject: RE: [PATCH 0/8] Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr > > Star, > > In many places in this patch series the return status is not checked. > > This means there is actually a behavior change with this series. The original > version had ASSERT() conditions. With this new version, the > ASSERT() conditions are replaced with error return codes. If the error > return codes > are not evaluated, then a build that has ASSERT() enabled and an ASSERT() > would be > triggered, will no longer see an ASSERT(). > > Mike > > > -----Original Message----- > > From: Zeng, Star > > Sent: Wednesday, June 15, 2016 1:44 AM > > To: edk2-devel@lists.01.org > > Cc: Yao, Jiewen <jiewen....@intel.com>; Gao, Liming > > <liming....@intel.com>; Kinney, Michael D > > <michael.d.kin...@intel.com>; Dong, Eric <eric.d...@intel.com>; Tian, > > Feng <feng.t...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Fu, Siyuan > > <siyuan...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com>; Carsey, Jaben > > <jaben.car...@intel.com>; Zhang, Chao B <chao.b.zh...@intel.com>; Fan, > > Jeff <jeff....@intel.com> > > Subject: [PATCH 0/8] Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr > > > > It is the follow up of 3ab41b7a325ca11a12b42f5ad1661c4b6791cb49 > > to replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr with > > UnicodeStrToAsciiStrS/AsciiStrToUnicodeStrS. > > > > Cc: Jiewen Yao <jiewen....@intel.com> > > Cc: Liming Gao <liming....@intel.com> > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > > Cc: Eric Dong <eric.d...@intel.com> > > Cc: Feng Tian <feng.t...@intel.com> > > Cc: Ruiyu Ni <ruiyu...@intel.com> > > Cc: Siyuan Fu <siyuan...@intel.com> > > Cc: Jiaxin Wu <jiaxin...@intel.com> > > Cc: Jaben Carsey <jaben.car...@intel.com> > > Cc: Chao Zhang <chao.b.zh...@intel.com> > > Cc: Jeff Fan <jeff....@intel.com> > > Star Zeng (8): > > MdePkg: Replace UnicodeStrToAsciiStr() with UnicodeStrToAsciiStrS() > > MdeModulePkg: Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr > > NetworkPkg: Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr > > PerformancePkg: Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr > > SecurityPkg: Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr > > ShellPkg: Replace UnicodeStrToAsciiStr/AsciiStrToUnicodeStr > > IntelFrameworkModulePkg: Replace > > UnicodeStrToAsciiStr/AsciiStrToUnicodeStr > > MdePkg: Indicate UnicodeStrToAsciiStr/AsciiStrToUnicodeStr to be > > deprecated > > > > .../Library/GenericBdsLib/BdsBoot.c | 4 +- > > .../Library/LegacyBootManagerLib/LegacyBm.c | 6 +- > > .../Universal/BdsDxe/FrontPage.c | 10 ++- > > MdeModulePkg/Application/UiApp/FrontPage.c | 2 +- > > .../UiApp/FrontPageCustomizedUiSupport.c | 6 +- > > MdeModulePkg/Bus/Sd/EmmcDxe/EmmcDxe.c | 2 +- > > MdeModulePkg/Bus/Sd/SdDxe/SdDxe.c | 2 +- > > MdeModulePkg/Library/DxeNetLib/DxeNetLib.c | 18 +++-- > > .../Library/UefiBootManagerLib/BmBootDescription.c | 4 +- > > .../Library/VarCheckHiiLib/VarCheckHiiGen.c | 6 +- > > .../HiiDatabaseDxe/ConfigKeywordHandler.c | 46 ++++++----- > > .../Universal/HiiDatabaseDxe/ConfigRouting.c | 42 +++++++---- > > MdePkg/Include/Library/BaseLib.h | 11 +++ > > MdePkg/Library/BaseLib/String.c | 11 ++- > > .../Library/UefiDevicePathLib/DevicePathFromText.c | 4 +- > > .../Library/UefiFileHandleLib/UefiFileHandleLib.c | 4 +- > > .../Application/IpsecConfig/PolicyEntryOperation.c | 6 +- > > NetworkPkg/HttpBootDxe/HttpBootClient.c | 19 +++-- > > NetworkPkg/HttpBootDxe/HttpBootConfig.c | 2 +- > > NetworkPkg/HttpDxe/HttpImpl.c | 8 +- > > NetworkPkg/HttpDxe/HttpProto.c | 8 +- > > NetworkPkg/IScsiDxe/IScsiConfig.c | 88 > > +++++++++++++++------- > > NetworkPkg/IScsiDxe/IScsiDriver.c | 2 +- > > NetworkPkg/IScsiDxe/IScsiMisc.c | 6 +- > > PerformancePkg/Dp_App/Dp.c | 6 +- > > PerformancePkg/Dp_App/DpTrace.c | 12 +-- > > SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalDriver.c | 4 +- > > SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c | 6 +- > > .../Tcg/Opal/OpalPasswordDxe/OpalHiiPrivate.h | 2 +- > > ShellPkg/Library/UefiDpLib/Dp.c | 8 +- > > ShellPkg/Library/UefiDpLib/DpTrace.c | 10 +-- > > ShellPkg/Library/UefiShellTftpCommandLib/Tftp.c | 8 +- > > 32 files changed, 232 insertions(+), 141 deletions(-) > > > > -- > > 2.7.0.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
