Thanks/Ray
> -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Ard Biesheuvel > Sent: Thursday, July 7, 2016 10:47 PM > To: Ni, Ruiyu <ruiyu...@intel.com> > Cc: edk2-devel-01 <edk2-devel@lists.01.org>; Gao, Liming > <liming....@intel.com> > Subject: Re: [edk2] [PATCH 1/2] Revert > "ShellPkg/UefiShellDebug1CommandsLib: remove unused but set variable" > > On 7 July 2016 at 06:36, Ruiyu Ni <ruiyu...@intel.com> wrote: > > This reverts commit e36ed7a84b2768443de22371f0aad5cf502328b1. > > The above commit fixed a build failure in > > "ShellPkg: Make the USB mouse behavior in 'edit' consistent with > > 'hexedit'.". > > Since the next patch will revert the USB mouse behavior fix, the > > "remove unused but set variable" fix is not needed. > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Ruiyu Ni　<ruiyu...@intel.com> > > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > > Cc: Liming Gao <liming....@intel.com> > > --- > > Thanks for putting me on cc > > Could you please merge this revert with the other one? Otherwise, you are > simply creating another point in the Git history where the build is broken. Good suggestion!:) > > Thanks, > Ard. > > > ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c | 4 > > ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git > > a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c > > b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c > > index 5acd8d4..fb0c76e 100644 > > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c > > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Edit/FileBuffer.c > > @@ -759,6 +759,7 @@ FileBufferRefresh ( > > > > UINTN StartRow; > > UINTN EndRow; > > + UINTN FStartRow; > > UINTN Tmp; > > > > Orig = MainEditor.ColorAttributes; > > @@ -831,6 +832,8 @@ FileBufferRefresh ( > > EndRow = Tmp; > > } > > > > + FStartRow = StartRow; > > + > > StartRow = 2 + StartRow - FileBuffer.LowVisibleRange.Row; > > EndRow = 2 + EndRow - FileBuffer.LowVisibleRange.Row; > > > > @@ -838,6 +841,7 @@ FileBufferRefresh ( > > // > > // not mouse selection actions > > // > > + FStartRow = FileBuffer.LowVisibleRange.Row; > > StartRow = 2; > > EndRow = (MainEditor.ScreenSize.Row - 1); > > } > > -- > > 2.8.3.windows.1 > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
