On 07/12/16 15:34, Laszlo Ersek wrote: > On 07/12/16 15:28, Ard Biesheuvel wrote: >> On 12 July 2016 at 13:21, Laszlo Ersek <ler...@redhat.com> wrote: >>> On 07/12/16 10:39, Laszlo Ersek wrote: >>>> On 07/12/16 07:18, Gao, Liming wrote: >>>>> Laszlo: >>>>> This patch serial is good. It will improve GenFds performance if there >>>>> are more padding in FD region. >>>>> >>>>> Reviewed-by: Liming Gao <liming....@intel.com> >>>> >>>> Thanks! >>>> >>>> Your R-b applies to patch #1 in the series as well, correct? (Just to be >>> >>> On a second thought, you did refer to the patch series in your message; >>> plus the second patch doesn't make a lot of sense without the first one. >>> So I'll take your R-b for the first patch as well. >>> >>> Series committed as 0f65154396df..bd907fb63865. >>> >> >> As a head's up, this patch appears to have broken ArmVirtQemu for me. > > Fantastic. I finally managed to let such a thing slip through my > testing. Sigh. :( > >> I am investigating atm > > Thanks. I'm sorry.
Jesus how could I be so incredibly stupid. In commit bd907fb6386560e621112beca7b7d381d0003967, I used the string.join() method, but I forgot to set the separator to the empty string. https://docs.python.org/2/library/string.html#string.join The paddings now contain 0x20 as every second byte. I'll send a patch soon. Thanks for the report. Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
