Reviewed-by: Chao Zhang <chao.b.zh...@intel.com>




Thanks & Best regards
Chao Zhang

-----Original Message-----
From: Gao, Liming 
Sent: Wednesday, July 13, 2016 8:28 PM
To: edk2-de...@ml01.01.org
Cc: Yao, Jiewen; Zhang, Chao B
Subject: [PATCH v2 5/5] SecurityPkg DxeTpmMeasureBootLib: Add comments in 
TcgMeasurePeImage()

The input PeImage in TcgMeasurePeImage() has been checked.

Cc: Jiewen Yao <jiewen....@intel.com>
Cc: Chao Zhang <chao.b.zh...@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming....@intel.com>
---
 SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c 
b/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c
index 25788b8..8ab60d8 100644
--- a/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c
+++ b/SecurityPkg/Library/DxeTpmMeasureBootLib/DxeTpmMeasureBootLib.c
@@ -13,11 +13,11 @@
   data structure within this image buffer before use.
 
   TcgMeasureGptTable() function will receive untrusted GPT partition table, 
and parse
   partition data carefully.
 
-Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2009 - 2016, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials 
 are licensed and made available under the terms and conditions of the BSD 
License 
 which accompanies this distribution.  The full text of the license may be 
found at 
 http://opensource.org/licenses/bsd-license.php
 
@@ -277,10 +277,13 @@ TcgMeasureGptTable (
 
   Caution: This function may receive untrusted input.
   PE/COFF image is external input, so this function will validate its data 
structure
   within this image buffer before use.
 
+  Notes: PE/COFF image has been checked by BasePeCoffLib 
PeCoffLoaderGetImageInfo() in 
+  its caller function DxeTpmMeasureBootHandler().
+
   @param[in] TcgProtocol    Pointer to the located TCG protocol instance.
   @param[in] ImageAddress   Start address of image buffer.
   @param[in] ImageSize      Image size
   @param[in] LinkTimeBase   Address that the image is loaded into memory.
   @param[in] ImageType      Image subsystem type.
-- 
1.9.5.msysgit.0

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to