Please check copyright.  I notice that at minimum EfiCompress.c and LoadPciRom 
need an update.

I think #8 has an error.  Replied to that email separately.

Is it worth moving "IfConfig6FreeArgList" to a shared library?  Looked like 
there were 2 copies...

Otherwise for the series
Reviewed-By: Jaben Carsey <jaben.car...@intel.com>

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Ruiyu Ni
> Sent: Thursday, July 14, 2016 2:30 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH 00/27] ShellPkg: Handle memory allocation failure
> Importance: High
> 
> The patch serials remove almost all assertions on memory allocation
> result, replaces with the error handling code.
> 
> https://github.com/niruiyu/edk2/commits/shell_assert
> 
> Ruiyu Ni (27):
>   ShellPkg/Shell.c: Handle memory allocation failure
>   ShellPkg/IsVolatileEnv: Handle memory allocation failure
>   ShellPkg/ShellAddEnvVarToList: Handle memory allocation failure
>   ShellPkg/ShellProtocol.c: Handle memory allocation failure
>   ShellPkg/Dp: Handle memory allocation failure
>   ShellPkg/UefiHandleParsingLib.c: Handle memory allocation failure
>   ShellPkg/UefiShellBcfgCommandLib: Handle memory allocation failure
>   ShellPkg/ConsistMapping.c: Handle memory allocation failure
>   ShellPkg/UefiShellCommandLib.c: Handle memory allocation failure
>   ShellPkg/DMem: Handle memory allocation failure
>   ShellPkg/EfiCompress: Handle memory allocation failure
>   ShellPkg/EfiDecompress: Handle memory allocation failure
>   ShellPkg/LoadPciRom: Handle memory allocation failure
>   ShellPkg/Edit: Handle memory allocation failure
>   ShellPkg/DevTree: Handle memory allocation failure
>   ShellPkg/DrvCfg: Handle memory allocation failure
>   ShellPkg/DrvDiag: Handle memory allocation failure
>   ShellPkg/For: Handle memory allocation failure
>   ShellPkg/If: Handle memory allocation failure
>   ShellPkg/Cd: Handle memory allocation failure
>   ShellPkg/Cp: Handle memory allocation failure
>   ShellPkg/Mv: Handle memory allocation failure
>   ShellPkg/UefiShellLib: Handle memory allocation failure
>   ShellPkg/IfConfig: Handle memory allocation failure
>   ShellPkg/UefiShellLib.c: Handle memory allocation failure
>   ShellPkg/Ifconfig6: Handle memory allocation failure
>   ShellPkg/Ping6: Handle memory allocation failure
> 
>  ShellPkg/Application/Shell/FileHandleWrappers.c    |  19 +-
>  ShellPkg/Application/Shell/Shell.c                 |  27 +-
>  ShellPkg/Application/Shell/ShellEnvVar.c           |  73 +--
>  ShellPkg/Application/Shell/ShellEnvVar.h           |  22 +-
>  .../Application/Shell/ShellParametersProtocol.c    |   5 +-
>  ShellPkg/Application/Shell/ShellProtocol.c         | 142 +++---
>  ShellPkg/Application/Shell/ShellProtocol.h         |  17 +-
>  ShellPkg/Library/UefiDpLib/Dp.c                    |   8 +-
>  .../UefiHandleParsingLib/UefiHandleParsingLib.c    |  55 ++-
>  .../UefiShellBcfgCommandLib.c                      |  47 +-
>  .../Library/UefiShellCommandLib/ConsistMapping.c   | 497 +++++++++++++-
> -------
>  .../UefiShellCommandLib/UefiShellCommandLib.c      |  34 +-
>  ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c |   6 +-
>  .../UefiShellDebug1CommandsLib/Edit/FileBuffer.c   |  41 +-
>  .../UefiShellDebug1CommandsLib/EfiCompress.c       |  28 +-
>  .../UefiShellDebug1CommandsLib/EfiDecompress.c     |  52 ++-
>  .../UefiShellDebug1CommandsLib/LoadPciRom.c        |   6 +-
>  .../Library/UefiShellDriver1CommandsLib/DevTree.c  |  13 +-
>  .../Library/UefiShellDriver1CommandsLib/DrvCfg.c   |  17 +-
>  .../Library/UefiShellDriver1CommandsLib/DrvDiag.c  |  17 +-
>  ShellPkg/Library/UefiShellLevel1CommandsLib/For.c  |  12 +-
>  ShellPkg/Library/UefiShellLevel1CommandsLib/If.c   |  95 ++--
>  ShellPkg/Library/UefiShellLevel2CommandsLib/Cd.c   |  34 +-
>  ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c   |  19 +-
>  ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c   |  14 +-
>  ShellPkg/Library/UefiShellLib/UefiShellLib.c       |  23 +-
>  .../UefiShellNetwork1CommandsLib/Ifconfig.c        |  77 +++-
>  .../UefiShellNetwork1CommandsLib.uni               |   1 +
>  .../UefiShellNetwork2CommandsLib/Ifconfig6.c       |  75 +++-
>  .../Library/UefiShellNetwork2CommandsLib/Ping6.c   |   6 +-
>  .../UefiShellNetwork2CommandsLib.uni               |   2 +
>  31 files changed, 954 insertions(+), 530 deletions(-)
> 
> --
> 2.9.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to