Feng,
The spec says " If the platform does not recognize the EFI_GUID in ResetData
the platform must pick a supported reset type to perform".
For the NULL instance of ResetSystemLib, I treat it as an implementation for a
Certain platform, then it's ok to let it pick a supported reset type to perform.
Thanks/Ray
> -----Original Message-----
> From: Tian, Feng
> Sent: Tuesday, August 23, 2016 11:22 AM
> To: Ni, Ruiyu <ruiyu...@intel.com>; edk2-devel@lists.01.org
> Cc: Chan, Amy <amy.c...@intel.com>; Tian, Feng <feng.t...@intel.com>
> Subject: RE: [PATCH 03/11] MdeModulePkg/BaseResetSystemLibNull:
> Implement ResetPlatformSpecific
>
> Do you need directly assert in ResetPlatformSpecific() for this NULL instance?
> Other series look good to me
>
> Reviewed-by: Feng Tian <feng.t...@intel.com>
>
> Thanks
> Feng
>
> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Wednesday, August 10, 2016 1:56 PM
> To: edk2-devel@lists.01.org
> Cc: Tian, Feng <feng.t...@intel.com>; Chan, Amy <amy.c...@intel.com>
> Subject: [PATCH 03/11] MdeModulePkg/BaseResetSystemLibNull:
> Implement ResetPlatformSpecific
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu...@intel.com>
> Cc: Feng Tian <feng.t...@intel.com>
> Cc: Amy Chan <amy.c...@intel.com>
> ---
> .../BaseResetSystemLibNull.c | 23
> +++++++++++++++++++++-
> 1 file changed, 22 insertions(+), 1 deletion(-)
>
> diff --git
> a/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNul
> l.c
> b/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNul
> l.c
> index d21a774..b233254 100644
> ---
> a/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNul
> l.c
> +++
> b/MdeModulePkg/Library/BaseResetSystemLibNull/BaseResetSystemLibNul
> l
> +++ .c
> @@ -1,7 +1,7 @@
> /** @file
> Null Reset System Library instance that only generates ASSERT() conditions.
>
> - Copyright (c) 2006 - 2009, Intel Corporation. All rights reserved.<BR>
> + Copyright (c) 2006 - 2016, Intel Corporation. All rights
> + reserved.<BR>
> This program and the accompanying materials
> are licensed and made available under the terms and conditions of the BSD
> License
> which accompanies this distribution. The full text of the license may be
> found at @@ -77,3 +77,24 @@ EnterS3WithImmediateWake ( {
> ASSERT (FALSE);
> }
> +
> +/**
> + This function causes a systemwide reset. The exact type of the reset
> +is defined
> + by the EFI_GUID that follows the Null-terminated Unicode string passed
> into ResetData.
> + If the platform does not recognize the EFI_GUID in ResetData the
> +platform must pick a
> + supported reset type to perform.The platform may optionally log the
> +parameters from
> + any non-normal reset that occurs.
> +
> + @param[in] DataSize The size, in bytes, of ResetData.
> + @param[in] ResetData The data buffer starts with a Null-terminated
> string, followed
> + by the EFI_GUID.
> +**/
> +VOID
> +EFIAPI
> +ResetPlatformSpecific (
> + IN UINTN DataSize,
> + IN VOID *ResetData
> + )
> +{
> + ResetCold ();
> +}
> --
> 2.9.0.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
