Change Looks good. Can you please clarify the commit message on why to change -_e type?
Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Abdul Lateef Attar > Sent: Monday, September 05, 2016 11:34 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] ShellPkg: pci -i -_e to print next capability > Importance: High > > According to PCI spec the next AER capability is relative to > the beginning of PCI configuration space. Hence substract the > base offset to get the next capability. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Abdul Lateef Attar <abdul-lateef.at...@hpe.com> > --- > ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > index 337495e..664c22b 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c > @@ -2370,7 +2370,7 @@ PCI_CONFIG_SPACE *mConfigSpace = NULL; > STATIC CONST SHELL_PARAM_ITEM ParamList[] = { > {L"-s", TypeValue}, > {L"-i", TypeFlag}, > - {L"-_e", TypeFlag}, > + {L"-_e", TypeValue}, > {NULL, TypeMax} > }; > > @@ -5914,7 +5914,7 @@ PciExplainPciExpress ( > // Advance to the next item if it exists > // > if (ExtHdr->NextCapabilityOffset != 0) { > - ExtHdr = (PCI_EXP_EXT_HDR*)((UINT8*)ExRegBuffer + ExtHdr- > >NextCapabilityOffset); > + ExtHdr = (PCI_EXP_EXT_HDR*)((UINT8*)ExRegBuffer + ExtHdr- > >NextCapabilityOffset - EFI_PCIE_CAPABILITY_BASE_OFFSET); > } else { > break; > } > -- > 2.7.4 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
