Sounds good! Thanks to confirm that. From: Carsey, Jaben Sent: Thursday, October 13, 2016 5:04 AM To: Yao, Jiewen <jiewen....@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Rothman, Michael A <michael.a.roth...@intel.com>; Kinney, Michael D <michael.d.kin...@intel.com>; 'edk2-devel@lists.01.org' <edk2-devel@lists.01.org> Cc: Tian, Feng <feng.t...@intel.com>; Zhang, Chao B <chao.b.zh...@intel.com>; Gao, Liming <liming....@intel.com>; Zeng, Star <star.z...@intel.com>; Carsey, Jaben <jaben.car...@intel.com> Subject: RE: [PATCH 17/45] MdeModulePkg/CapsuleApp: Add CapsuleApp application.
I agree. We should move the 3 protocols from the UEFI Shell Specification from ShellPkg to MdePkg. I think that this is a non-backwards-compatible-change and will require a new GUID in ShellPkg. -Jaben From: Yao, Jiewen Sent: Tuesday, October 11, 2016 7:45 AM To: Ni, Ruiyu <ruiyu...@intel.com<mailto:ruiyu...@intel.com>>; Carsey, Jaben <jaben.car...@intel.com<mailto:jaben.car...@intel.com>>; Rothman, Michael A <michael.a.roth...@intel.com<mailto:michael.a.roth...@intel.com>>; Kinney, Michael D <michael.d.kin...@intel.com<mailto:michael.d.kin...@intel.com>>; 'edk2-devel@lists.01.org' <edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>> Cc: Tian, Feng <feng.t...@intel.com<mailto:feng.t...@intel.com>>; Zhang, Chao B <chao.b.zh...@intel.com<mailto:chao.b.zh...@intel.com>>; Gao, Liming <liming....@intel.com<mailto:liming....@intel.com>>; Zeng, Star <star.z...@intel.com<mailto:star.z...@intel.com>> Subject: RE: [PATCH 17/45] MdeModulePkg/CapsuleApp: Add CapsuleApp application. Importance: High Yes, I think that is a very good idea. Shell spec defines EFI_SHELL_PROTOCOL, EFI_SHELL_DYNAMIC_COMMAND_PROTOCOL, EFI_SHELL_PARAMETERS_PROTOCOL. These should be treated as industry stand and we can move these 3 to MdePkg. SHELL_ENVIRONMENT_2_PROTOCOL and SHELL_INTERFACE_PROTOCOL should be still in ShellPkg, since it is not standard. Thank you Yao Jiewen From: Ni, Ruiyu Sent: Tuesday, October 11, 2016 4:28 PM To: Carsey, Jaben <jaben.car...@intel.com<mailto:jaben.car...@intel.com>>; Rothman, Michael A <michael.a.roth...@intel.com<mailto:michael.a.roth...@intel.com>>; Yao, Jiewen <jiewen....@intel.com<mailto:jiewen....@intel.com>>; Kinney, Michael D <michael.d.kin...@intel.com<mailto:michael.d.kin...@intel.com>>; 'edk2-devel@lists.01.org' <edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>> Cc: Tian, Feng <feng.t...@intel.com<mailto:feng.t...@intel.com>>; Zhang, Chao B <chao.b.zh...@intel.com<mailto:chao.b.zh...@intel.com>>; Gao, Liming <liming....@intel.com<mailto:liming....@intel.com>>; Zeng, Star <star.z...@intel.com<mailto:star.z...@intel.com>> Subject: RE: [PATCH 17/45] MdeModulePkg/CapsuleApp: Add CapsuleApp application. Jaben, The reason I propose to move the Shell protocol definitions to MdePkg is that all applications that wants to use the ARGV can use the ShellParameter protocol, without depending on ShellPkg. Thanks/Ray From: Ni, Ruiyu Sent: Tuesday, October 11, 2016 4:08 PM To: Carsey, Jaben <jaben.car...@intel.com<mailto:jaben.car...@intel.com>>; Rothman, Michael A <michael.a.roth...@intel.com<mailto:michael.a.roth...@intel.com>>; Yao, Jiewen <jiewen....@intel.com<mailto:jiewen....@intel.com>>; Kinney, Michael D <michael.d.kin...@intel.com<mailto:michael.d.kin...@intel.com>>; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org> Cc: Tian, Feng <feng.t...@intel.com<mailto:feng.t...@intel.com>>; Zhang, Chao B <chao.b.zh...@intel.com<mailto:chao.b.zh...@intel.com>>; Gao, Liming <liming....@intel.com<mailto:liming....@intel.com>>; Zeng, Star <star.z...@intel.com<mailto:star.z...@intel.com>> Subject: RE: [PATCH 17/45] MdeModulePkg/CapsuleApp: Add CapsuleApp application. Jaben, How about moving the contents in ShellPkg\Include\Protocol\ to MdePkg\Include\Protocol\? All industry standard protocols are defined in MdePkg, except the Shell related protocols. Thanks/Ray _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
