I actually off-line reviewed the 11 patches before sending them out.

Reviewed-by: Ruiyu Ni <ruiyu...@intel.com>

Regards,
Ray

>-----Original Message-----
>From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Ruiyu Ni
>Sent: Friday, September 30, 2016 4:18 PM
>To: edk2-devel@lists.01.org
>Subject: [edk2] [PATCH 00/11] Remove unnecessary EFIAPI
>
>Many Shell internal functions have EFIAPI modifier.
>But it's not necessary. The patch serials remove the unnecessary
>EFIAPI.
>
>Ruiyu Ni (11):
>  ShellPkg/Shell: Remove unnecessary EFIAPI
>  ShellPkg/UefiShellDebug1CommandsLib: Remove unnecessary EFIAPI
>  ShellPkg/UefiShellDriver1CommandsLib: Remove unnecessary EFIAPI
>  ShellPkg/UefiShellLevel1CommandsLib: Remove unnecessary EFIAPI
>  ShellPkg/UefiShellLevel2CommandsLib: Remove unnecessary EFIAPI
>  ShellPkg/UefiShellLevel3CommandsLib: Remove unnecessary EFIAPI
>  ShellPkg/UefiShellParsingLib: Remove unnecessary EFIAPI
>  ShellPkg/UefiShellBcfgCommandLib: Remove unnecessary EFIAPI
>  ShellPkg/UefiShellCommandLib: Remove unnecessary EFIAPI
>  ShellPkg/UefiShellLib: Remove unnecessary EFIAPI
>  ShellPkg/UefiShellNetwork1CommandsLib: Remove unnecessary EFIAPI
>
> ShellPkg/Application/Shell/ConsoleLogger.c         | 10 -----
> ShellPkg/Application/Shell/ConsoleLogger.h         |  6 ---
> ShellPkg/Application/Shell/ConsoleWrappers.c       |  4 --
> ShellPkg/Application/Shell/ConsoleWrappers.h       |  4 --
> ShellPkg/Application/Shell/FileHandleInternal.h    |  3 --
> ShellPkg/Application/Shell/FileHandleWrappers.c    |  6 ---
> ShellPkg/Application/Shell/FileHandleWrappers.h    |  2 -
> ShellPkg/Application/Shell/Shell.c                 | 36 -----------------
> ShellPkg/Application/Shell/Shell.h                 | 16 --------
> ShellPkg/Application/Shell/ShellEnvVar.c           |  4 --
> ShellPkg/Application/Shell/ShellEnvVar.h           |  4 --
> ShellPkg/Application/Shell/ShellManParser.c        |  9 -----
> ShellPkg/Application/Shell/ShellManParser.h        |  2 -
> .../Application/Shell/ShellParametersProtocol.c    | 14 -------
> .../Application/Shell/ShellParametersProtocol.h    |  8 ----
> ShellPkg/Application/Shell/ShellProtocol.c         | 25 ++----------
> ShellPkg/Application/Shell/ShellProtocol.h         |  9 -----
> .../UefiHandleParsingLib/UefiHandleParsingLib.c    |  6 ---
> .../UefiShellBcfgCommandLib.c                      |  9 -----
> .../Library/UefiShellCommandLib/ConsistMapping.c   |  3 --
> .../UefiShellCommandLib/UefiShellCommandLib.c      |  6 ---
> .../Library/UefiShellDebug1CommandsLib/Compress.c  | 30 ---------------
> ShellPkg/Library/UefiShellDebug1CommandsLib/Dblk.c |  1 -
> ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c |  2 -
> .../Library/UefiShellDebug1CommandsLib/DmpStore.c  |  3 --
> .../UefiShellDebug1CommandsLib/Edit/FileBuffer.c   | 45 ----------------------
> .../UefiShellDebug1CommandsLib/Edit/FileBuffer.h   | 17 --------
> .../Edit/MainTextEditor.c                          |  9 -----
> .../Edit/MainTextEditor.h                          |  5 ---
> .../Library/UefiShellDebug1CommandsLib/Edit/Misc.c |  2 -
> .../Library/UefiShellDebug1CommandsLib/Edit/Misc.h |  2 -
> .../UefiShellDebug1CommandsLib/EditInputBar.c      |  7 ----
> .../UefiShellDebug1CommandsLib/EditInputBar.h      |  6 ---
> .../UefiShellDebug1CommandsLib/EditMenuBar.c       |  6 ---
> .../UefiShellDebug1CommandsLib/EditMenuBar.h       |  6 ---
> .../UefiShellDebug1CommandsLib/EditStatusBar.c     |  7 ----
> .../UefiShellDebug1CommandsLib/EditStatusBar.h     |  7 ----
> .../UefiShellDebug1CommandsLib/EditTitleBar.c      |  3 --
> .../UefiShellDebug1CommandsLib/EditTitleBar.h      |  3 --
> .../HexEdit/BufferImage.c                          |  9 -----
> .../HexEdit/BufferImage.h                          |  4 --
> .../UefiShellDebug1CommandsLib/HexEdit/DiskImage.c |  1 -
> .../HexEdit/MainHexEditor.c                        |  1 -
> .../HexEdit/MainHexEditor.h                        |  1 -
> .../UefiShellDebug1CommandsLib/LoadPciRom.c        |  2 -
> ShellPkg/Library/UefiShellDebug1CommandsLib/Mm.c   |  1 -
> ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c  | 18 ---------
> .../Library/UefiShellDebug1CommandsLib/SerMode.c   |  1 -
> .../Library/UefiShellDebug1CommandsLib/SetVar.c    |  1 -
> .../SmbiosView/EventLogInfo.c                      |  5 ---
> .../SmbiosView/EventLogInfo.h                      |  5 ---
> .../SmbiosView/SmbiosView.c                        |  8 ----
> .../SmbiosView/SmbiosView.h                        |  7 ----
> .../UefiShellDebug1CommandsLib.c                   |  9 -----
> .../UefiShellDebug1CommandsLib.h                   |  7 ----
> .../Library/UefiShellDriver1CommandsLib/Connect.c  |  3 --
> .../Library/UefiShellDriver1CommandsLib/DevTree.c  |  1 -
> .../Library/UefiShellDriver1CommandsLib/Devices.c  |  1 -
> ShellPkg/Library/UefiShellDriver1CommandsLib/Dh.c  |  9 -----
> .../UefiShellDriver1CommandsLib/Disconnect.c       |  1 -
> .../Library/UefiShellDriver1CommandsLib/Drivers.c  |  4 --
> .../Library/UefiShellDriver1CommandsLib/DrvCfg.c   |  7 ----
> .../Library/UefiShellDriver1CommandsLib/DrvDiag.c  |  1 -
> .../Library/UefiShellDriver1CommandsLib/OpenInfo.c |  1 -
> .../UefiShellDriver1CommandsLib.h                  |  1 -
> .../Library/UefiShellDriver1CommandsLib/Unload.c   |  1 -
> ShellPkg/Library/UefiShellLevel1CommandsLib/For.c  |  5 ---
> ShellPkg/Library/UefiShellLevel1CommandsLib/If.c   |  6 ---
> .../UefiShellLevel1CommandsLib.c                   |  2 -
> .../UefiShellLevel1CommandsLib.h                   |  1 -
> ShellPkg/Library/UefiShellLevel2CommandsLib/Cp.c   |  4 --
> ShellPkg/Library/UefiShellLevel2CommandsLib/Load.c |  2 -
> ShellPkg/Library/UefiShellLevel2CommandsLib/Ls.c   |  5 ---
> ShellPkg/Library/UefiShellLevel2CommandsLib/Map.c  | 12 ------
> ShellPkg/Library/UefiShellLevel2CommandsLib/Mv.c   |  7 ----
> .../Library/UefiShellLevel2CommandsLib/Parse.c     |  3 --
> ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c   |  3 --
> ShellPkg/Library/UefiShellLevel2CommandsLib/Set.c  |  1 -
> .../Library/UefiShellLevel2CommandsLib/TimeDate.c  |  4 --
> .../UefiShellLevel2CommandsLib.c                   |  5 ---
> .../UefiShellLevel2CommandsLib.h                   |  6 ---
> ShellPkg/Library/UefiShellLevel2CommandsLib/Vol.c  |  1 -
> .../Library/UefiShellLevel3CommandsLib/Alias.c     |  1 -
> ShellPkg/Library/UefiShellLevel3CommandsLib/Help.c |  4 --
> .../Library/UefiShellLevel3CommandsLib/Touch.c     |  2 -
> ShellPkg/Library/UefiShellLevel3CommandsLib/Type.c |  1 -
> ShellPkg/Library/UefiShellLib/UefiShellLib.c       | 14 -------
> ShellPkg/Library/UefiShellLib/UefiShellLib.h       |  2 -
> .../Library/UefiShellNetwork1CommandsLib/Ping.c    | 14 -------
> 89 files changed, 4 insertions(+), 558 deletions(-)
>
>--
>2.9.0.windows.1
>
>_______________________________________________
>edk2-devel mailing list
>edk2-devel@lists.01.org
>https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to