On 17 October 2016 at 09:54, Dennis Chen <dennis.c...@arm.com> wrote: > Since ACPI spec defines the GIC base addresses (CPU interface, > Distributor and Redistributor*GICv3 only*) as 64-bit, so we should > define these corresponding base address variables as 64-bit instead of > 32-bit. This patch redefines them according to the ACPI spec. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Signed-off-by: Dennis Chen <dennis.c...@arm.com>
After a closer look, I noticed the following: ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase, ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicDistributorBase, ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase, ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicInterruptInterfaceBase, ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicInterruptInterfaceBase, ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase, ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicDistributorBase, ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicRedistributorBase, ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicDistributorBase, ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicRedistributorBase, ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicDistributorBase, ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicRedistributorBase, ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicDistributorBase, ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase ArmPkg/Include/Library/ArmGicLib.h: IN INTN GicInterruptInterfaceBase ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicInterruptInterfaceBase ArmPkg/Include/Library/ArmGicLib.h: IN UINTN GicInterruptInterfaceBase, so I think we need to clean up the use of these values more widely than we have done up till now Leif: I was wondering if EFI_PHYSICAL_ADDRESS would be more appropriate for MMIO base addresses? _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
