Reviewed-by: Jaben Carsey <jaben.car...@intel.com> > -----Original Message----- > From: Tim Lewis [mailto:tim.le...@insyde.com] > Sent: Tuesday, October 18, 2016 5:44 AM > To: Laszlo Ersek <ler...@redhat.com>; edk2-devel-01 <edk2- > de...@ml01.01.org> > Cc: Carsey, Jaben <jaben.car...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com> > Subject: RE: [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in > EfiShellGetGuidFromName() > Importance: High > > Reviewed-by: Tim Lewis <tim.le...@insyde.com> > > -----Original Message----- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Tuesday, October 18, 2016 4:07 AM > To: edk2-devel-01 <edk2-de...@ml01.01.org> > Cc: Jaben Carsey <jaben.car...@intel.com>; Ruiyu Ni <ruiyu...@intel.com>; > Tim Lewis <tim.le...@insyde.com> > Subject: [PATCH] ShellPkg/Shell: fix CopyGuid() arg order in > EfiShellGetGuidFromName() > > The destination GUID comes first; from > "MdePkg/Include/Library/BaseMemoryLib.h": > > > GUID * > > EFIAPI > > CopyGuid ( > > OUT GUID *DestinationGuid, > > IN CONST GUID *SourceGuid > > ); > > Here "NewGuid" is the GUID looked up by GetGuidFromStringName(), and > "Guid" is where EfiShellGetGuidFromName() has to propagate that result to. > > Cc: Jaben Carsey <jaben.car...@intel.com> > Cc: Ruiyu Ni <ruiyu...@intel.com> > Cc: Tim Lewis <tim.le...@insyde.com> > Reported-by: Tim Lewis <tim.le...@insyde.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > --- > ShellPkg/Application/Shell/ShellProtocol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ShellPkg/Application/Shell/ShellProtocol.c > b/ShellPkg/Application/Shell/ShellProtocol.c > index 2bc0646b453d..04b66c5acaae 100644 > --- a/ShellPkg/Application/Shell/ShellProtocol.c > +++ b/ShellPkg/Application/Shell/ShellProtocol.c > @@ -2207,7 +2207,7 @@ EfiShellGetGuidFromName( > Status = GetGuidFromStringName(GuidName, NULL, &NewGuid); > > if (!EFI_ERROR(Status)) { > - CopyGuid(NewGuid, Guid); > + CopyGuid(Guid, NewGuid); > } > > return (Status); > -- > 2.9.2
_______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
