On 21 October 2016 at 22:27, Laszlo Ersek <ler...@redhat.com> wrote:
> These are deprecated / disabled under the
> DISABLE_NEW_DEPRECATED_INTERFACES feature test macro.
>
> Introduce a variable called PcdStatus, and use it to assert the success of
> these operations (there is no reason for them to fail here).
>
> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=165
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Laszlo Ersek <ler...@redhat.com>
Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org>
> ---
> ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
> b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
> index aecad570a04f..56f4c921b513 100644
> --- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
> +++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
> @@ -578,6 +578,8 @@ PlatformBootManagerBeforeConsole (
> VOID
> )
> {
> + RETURN_STATUS PcdStatus;
> +
> //
> // Signal EndOfDxe PI Event
> //
> @@ -629,7 +631,9 @@ PlatformBootManagerBeforeConsole (
> //
> // Set the front page timeout from the QEMU configuration.
> //
> - PcdSet16 (PcdPlatformBootTimeOut, GetFrontPageTimeoutFromQemu ());
> + PcdStatus = PcdSet16S (PcdPlatformBootTimeOut,
> + GetFrontPageTimeoutFromQemu ());
> + ASSERT_RETURN_ERROR (PcdStatus);
>
> //
> // Register platform-specific boot options and keyboard shortcuts.
> --
> 2.9.2
>
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
