All,
Just a quick observation to request comments:

Since a lot of the code in BaseXApicX2ApicLib.c and BaseXApicLib is the same, 
how about we merge the common code and build the libraries from the same 
directory?

UefiCpuPkg/Library/LocalApilLib/
- LocalApicLib.c --> common code
- BaseXApicLib.c --> legacy APIC code
- BaseXApicX2ApicLib.c --> X2APIC code
- BaseXApicLib.inf -> builds from LocalApicLib.c + BaseXApicLib.c
- BaseXApicX2ApicLib.inf -> builds from LocalApicLib.c + BaseXApicX2ApicLib.c

Of course, doing this would require modification to existing .DSC files, to 
point to the appropriate .INF under the merged LocalApicLib directory.
Would that be too disruptive?

Leo.





_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to