On 1 December 2016 at 16:45, Leif Lindholm <[email protected]> wrote: > Commit 0a99a65d2c8a ("fix incorrect device address of double buffer") > retained an explicit cast on the variable "Buffer" which became > incorrect with the other changes, leading to compilation failures > with some toolchains. Drop the cast. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Reported-by: Sudeep Holla <[email protected]> > Signed-off-by: Leif Lindholm <[email protected]>
Reviewed-by: Ard Biesheuvel <[email protected]> > --- > > Mike, Andrew - since Ard is on holiday and the fix is trivial, > could either of you give me a Reviewed-by: on this one? > > ArmPkg/Library/ArmDmaLib/ArmDmaLib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c > b/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c > index acc106b..f4ee9e4 100644 > --- a/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c > +++ b/ArmPkg/Library/ArmDmaLib/ArmDmaLib.c > @@ -142,7 +142,7 @@ DmaMap ( > CopyMem (Buffer, HostAddress, *NumberOfBytes); > } > > - *DeviceAddress = HostToDeviceAddress (ConvertToPhysicalAddress > ((UINTN)Buffer)); > + *DeviceAddress = HostToDeviceAddress (ConvertToPhysicalAddress > (Buffer)); > Map->BufferAddress = Buffer; > } else { > Map->DoubleBuffer = FALSE; > -- > 2.10.2 > _______________________________________________ edk2-devel mailing list [email protected] https://lists.01.org/mailman/listinfo/edk2-devel
