Reviewed-by: jiewen....@intel.com

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen....@intel.com>; Fan, Jeff <jeff....@intel.com>
> Subject: [edk2] [patch 14/18] UefiCpuPkg/MicrocodeUpdateDxe: Fix coding style
> issues in INF file
> 
> 1. Add MicrocodeUpdate.h to the [Sources] section.
> 2. Fix the incorrect Guid/Protocol format issues.
> 
> Cc: Jiewen Yao <jiewen....@intel.com>
> Cc: Jeff Fan <jeff....@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan...@intel.com>
> ---
>  UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf
> | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git
> a/UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.in
> f
> b/UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.in
> f
> index 437d300..7aae348 100644
> ---
> a/UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.in
> f
> +++
> b/UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.in
> f
> @@ -28,10 +28,11 @@ [Defines]
>  #
>  #  VALID_ARCHITECTURES           = X64
>  #
> 
>  [Sources]
> +  MicrocodeUpdate.h
>    MicrocodeFmp.c
>    MicrocodeUpdate.c
> 
>  [Packages]
>    MdePkg/MdePkg.dec
> @@ -49,14 +50,14 @@ [LibraryClasses]
>    UefiRuntimeServicesTableLib
>    UefiDriverEntryPoint
>    MicrocodeFlashAccessLib
> 
>  [Guids]
> -  gMicrocodeFmpImageTypeIdGuid
> +  gMicrocodeFmpImageTypeIdGuid                  ## CONSUMES   ##
> GUID
> 
>  [Protocols]
> -  gEfiFirmwareManagementProtocolGuid            ##
> SOMTIMES_PRODUCE
> +  gEfiFirmwareManagementProtocolGuid            ## PRODUCES
> 
>  [Pcd]
>    gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress
> ## CONSUMES
>    gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize
> ## CONSUMES
> 
> --
> 1.9.5.msysgit.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to