On 16 January 2017 at 15:06, Bhupesh Sharma <bhsha...@redhat.com> wrote:
> While debugging OS for ACPI BGRT support (especially on VMs),
> it is very useful to have the EFI firmware to export the
> ACPI BGRT table.
>
> This patch tries to add this support in ArmVirtPkg.
>
> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>
> Cc: Laszlo Ersek <ler...@redhat.com>
> Signed-off-by: Bhupesh Sharma <bhsha...@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.0

Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org>

Pushed as 13a50a6fe1dc

When booting in graphical mode, acpidump gives me

BGRT @ 0x000000013BC90000
  0000: 42 47 52 54 38 00 00 00 01 70 49 4E 54 45 4C 20  BGRT8....pINTEL
  0010: 45 44 4B 32 20 20 20 20 02 00 00 00 20 20 20 20  EDK2    ....
  0020: 13 00 00 01 01 00 01 00 00 30 FF FF 00 00 00 00  .........0......
  0030: 2F 01 00 00 0F 01 00 00                          /.......

which looks close enough to me (I haven't attempted to decode the
contents to figure out whether they make sense or not)

Thanks!


> ---
>  ArmVirtPkg/ArmVirtQemu.dsc           | 1 +
>  ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 1 +
>  ArmVirtPkg/ArmVirtQemuKernel.dsc     | 1 +
>  3 files changed, 3 insertions(+)
>
> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> index 0cae9968f4ea..8fe3c3816961 100644
> --- a/ArmVirtPkg/ArmVirtQemu.dsc
> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> @@ -390,6 +390,7 @@
>    #
>    # ACPI Support
>    #
> +  
> MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf
>    OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf {
>      <LibraryClasses>
>        NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
> diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc 
> b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> index a2e82b3179e8..cc5d12aaefea 100644
> --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> @@ -145,6 +145,7 @@ READ_LOCK_STATUS   = TRUE
>    # ACPI Support
>    #
>    INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
> +  INF 
> MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf
>    INF OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf
>
>    #
> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc 
> b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> index fe76c2263faa..aa40374745af 100644
> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc
> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc
> @@ -379,6 +379,7 @@
>    #
>    # ACPI Support
>    #
> +  
> MdeModulePkg/Universal/Acpi/BootGraphicsResourceTableDxe/BootGraphicsResourceTableDxe.inf
>    OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf {
>      <LibraryClasses>
>        NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
> --
> 2.7.4
>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Reply via email to