REF: https://bugzilla.tianocore.org/show_bug.cgi?id=298
Then this event empty function can be used to remove
the duplication in drivers and other libraries.
Cc: Liming Gao <liming....@intel.com>
Cc: Michael D Kinney <michael.d.kin...@intel.com>
Cc: Jeff Fan <jeff....@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Star Zeng <star.z...@intel.com>
---
.../Library/FrameworkUefiLib/UefiLib.c | 42 +++++++++++-----------
.../Library/FrameworkUefiLib/UefiLibInternal.h | 20 +----------
.../Library/FrameworkUefiLib/UefiNotTiano.c | 4 +--
3 files changed, 23 insertions(+), 43 deletions(-)
diff --git a/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c
b/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c
index e198b729a329..30b6dc921828 100644
--- a/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c
+++ b/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLib.c
@@ -5,7 +5,7 @@
EFI Driver Model related protocols, manage Unicode string tables for UEFI
Drivers,
and print messages on the console output and standard error devices.
- Copyright (c) 2006 - 2008, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2006 - 2017, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD
License
which accompanies this distribution. The full text of the license may be
found at
@@ -310,7 +310,7 @@ EfiEventGroupSignal (
Status = gBS->CreateEventEx (
EVT_NOTIFY_SIGNAL,
TPL_CALLBACK,
- InternalEmptyFunction,
+ EfiEventEmptyFunction,
NULL,
EventGroup,
&Event
@@ -325,6 +325,24 @@ EfiEventGroupSignal (
return Status;
}
+/**
+ An empty function that can be used as NotifyFunction parameter of
+ CreateEvent() or CreateEventEx().
+
+ @param Event Event whose notification function is being invoked.
+ @param Context The pointer to the notification function's context,
+ which is implementation-dependent.
+
+**/
+VOID
+EFIAPI
+EfiEventEmptyFunction (
+ IN EFI_EVENT Event,
+ IN VOID *Context
+ )
+{
+}
+
/**
Returns the current TPL.
@@ -1457,23 +1475,3 @@ GetBestLanguage (
//
return NULL;
}
-
-/**
- An empty function to pass error checking of CreateEventEx ().
-
- This empty function ensures that EVT_NOTIFY_SIGNAL_ALL is error
- checked correctly since it is now mapped into CreateEventEx() in UEFI 2.0.
-
- @param Event Event whose notification function is being
invoked.
- @param Context Pointer to the notification function's context,
- which is implementation-dependent.
-
-**/
-VOID
-EFIAPI
-InternalEmptyFunction (
- IN EFI_EVENT Event,
- IN VOID *Context
- )
-{
-}
diff --git a/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLibInternal.h
b/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLibInternal.h
index 16c663626db2..51f58176defa 100644
--- a/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLibInternal.h
+++ b/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiLibInternal.h
@@ -1,7 +1,7 @@
/** @file
Internal include file for UefiLib.
- Copyright (c) 2007 - 2008, Intel Corporation. All rights reserved.<BR>
+ Copyright (c) 2007 - 2017, Intel Corporation. All rights reserved.<BR>
This program and the accompanying materials
are licensed and made available under the terms and conditions of the BSD
License
which accompanies this distribution. The full text of the license may be
found at
@@ -41,22 +41,4 @@
#include <Library/PrintLib.h>
#include <Library/DevicePathLib.h>
-/**
- An empty function to pass error checking of CreateEventEx ().
-
- This empty function ensures that EVT_NOTIFY_SIGNAL_ALL is error
- checked correctly since it is now mapped into CreateEventEx() in UEFI 2.0.
-
- @param Event Event whose notification function is being
invoked.
- @param Context Pointer to the notification function's context,
- which is implementation-dependent.
-
-**/
-VOID
-EFIAPI
-InternalEmptyFunction (
- IN EFI_EVENT Event,
- IN VOID *Context
- );
-
#endif
diff --git a/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiNotTiano.c
b/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiNotTiano.c
index 1221403672f9..e641aba647bb 100644
--- a/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiNotTiano.c
+++ b/IntelFrameworkPkg/Library/FrameworkUefiLib/UefiNotTiano.c
@@ -45,7 +45,7 @@ EfiCreateEventLegacyBoot (
{
return EfiCreateEventLegacyBootEx (
TPL_CALLBACK,
- InternalEmptyFunction,
+ EfiEventEmptyFunction,
NULL,
LegacyBootEvent
);
@@ -135,7 +135,7 @@ EfiCreateEventReadyToBoot (
{
return EfiCreateEventReadyToBootEx (
TPL_CALLBACK,
- InternalEmptyFunction,
+ EfiEventEmptyFunction,
NULL,
ReadyToBootEvent
);
--
2.7.0.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
