MdeModulePkg reviewed-by: Feng Tian <feng.t...@intel.com> -----Original Message----- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Thursday, January 19, 2017 6:30 PM To: Zeng, Star <star.z...@intel.com>; edk2-devel@lists.01.org <edk2-de...@ml01.01.org>; Kinney, Michael D <michael.d.kin...@intel.com>; Fan, Jeff <jeff....@intel.com>; Tian, Feng <feng.t...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Ma, Maurice <maurice...@intel.com>; Agyeman, Prince <prince.agye...@intel.com>; Steele, Kelly <kelly.ste...@intel.com>; Leif Lindholm <leif.lindh...@linaro.org> Cc: Gao, Liming <liming....@intel.com>; Ard Biesheuvel <ard.biesheu...@linaro.org> Subject: Re: [edk2] [PATCH 0/7] Make the event empty function in UefiLib public
Hi Star, On 01/19/17 11:27, Zeng, Star wrote: > Hi, > > Please kindly help take a review to the patches. :) > > So far, I have got the RB from Liming and Ard to MdePkg and ArmPlatformPkg. I didn't ignore the series, it's just that I don't co-maintain any of the packages being modified. Thanks Laszlo > -----Original Message----- > From: Zeng, Star > Sent: Tuesday, January 17, 2017 3:09 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com>; Gao, Liming > <liming....@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Fan, Jeff <jeff....@intel.com>; Tian, > Feng <feng.t...@intel.com>; Ni, Ruiyu <ruiyu...@intel.com>; Ma, > Maurice <maurice...@intel.com>; Agyeman, Prince > <prince.agye...@intel.com>; Steele, Kelly <kelly.ste...@intel.com>; > Leif Lindholm <leif.lindh...@linaro.org>; Ard Biesheuvel > <ard.biesheu...@linaro.org>; Laszlo Ersek <ler...@redhat.com> > Subject: [PATCH 0/7] Make the event empty function in UefiLib public > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=298 > > We found there are many event empty functions in EDK2 code base, these > patches are to make the event empty function in UefiLib public, then this > event empty function can be used to remove the duplication in drivers and > other libraries. > > In CorebootPayloadPkg/QuarkPlatformPkg/ArmPlatformPkg, EfiEventGroupSignal > from UefiLib can be used to remove the duplication of event empty function. > > Cc: Liming Gao <liming....@intel.com> > Cc: Michael Kinney <michael.d.kin...@intel.com> > Cc: Jeff Fan <jeff....@intel.com> > Cc: Feng Tian <feng.t...@intel.com> > Cc: Ruiyu Ni <ruiyu...@intel.com> > Cc: Maurice Ma <maurice...@intel.com> > Cc: Prince Agyeman <prince.agye...@intel.com> > Cc: Kelly Steele <kelly.ste...@intel.com> > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Cc: Laszlo Ersek <ler...@redhat.com> > > Star Zeng (7): > MdePkg UefiLib: Make the event empty function public > IntelFrameworkPkg UefiLib: Make the event empty function public > MdeModulePkg: Use EfiEventEmptyFunction from UefiLib > IntelFrameworkModulePkg: Use EfiEventEmptyFunction from UefiLib > CorebootPayloadPkg: Use EfiEventGroupSignal from UefiLib > QuarkPlatformPkg: Use EfiEventGroupSignal from UefiLib > ArmPlatformPkg: Use EfiEventGroupSignal from UefiLib > > .../Library/PlatformIntelBdsLib/IntelBdsPlatform.c | 36 ++----------------- > .../Library/PlatformIntelBdsLib/IntelBdsPlatform.h | 3 +- > .../PlatformIntelBdsLib/PlatformIntelBdsLib.inf | 3 +- > .../PlatformBootManagerLib/PlatformBootManager.c | 25 ++----------- > .../Universal/BdsDxe/BdsEntry.c | 20 +---------- > .../Library/FrameworkUefiLib/UefiLib.c | 42 > +++++++++++----------- > .../Library/FrameworkUefiLib/UefiLibInternal.h | 20 +---------- > .../Library/FrameworkUefiLib/UefiNotTiano.c | 4 +-- > MdeModulePkg/Core/Dxe/Dispatcher/Dispatcher.c | 23 ++---------- > MdeModulePkg/Core/Dxe/DxeMain.h | 18 +--------- > MdeModulePkg/Core/Dxe/Event/Event.c | 4 +-- > MdeModulePkg/Library/UefiBootManagerLib/BmHotkey.c | 19 ++-------- > .../Universal/Console/ConSplitterDxe/ConSplitter.c | 22 ++---------- > .../Universal/Console/ConSplitterDxe/ConSplitter.h | 18 +--------- > .../Universal/DriverSampleDxe/DriverSample.c | 20 ++--------- > .../Universal/SetupBrowserDxe/Presentation.c | 20 ++--------- > MdePkg/Include/Library/UefiLib.h | 18 +++++++++- > MdePkg/Library/UefiLib/UefiLib.c | 42 > +++++++++++----------- > MdePkg/Library/UefiLib/UefiLibInternal.h | 20 +---------- > MdePkg/Library/UefiLib/UefiNotTiano.c | 10 +++--- > .../PlatformBootManagerLib/PlatformBootManager.c | 25 ++----------- > 21 files changed, 91 insertions(+), 321 deletions(-) > > -- > 2.7.0.windows.1 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel