Yes, please. :) Thanks, Star -----Original Message----- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Laszlo Ersek Sent: Monday, March 20, 2017 5:46 PM To: Zeng, Star <star.z...@intel.com>; edk2-devel-01 <edk2-devel@lists.01.org> Cc: Wu, Hao A <hao.a...@intel.com>; Tian, Feng <feng.t...@intel.com>; Leif Lindholm <leif.lindh...@linaro.org>; Ard Biesheuvel <ard.biesheu...@linaro.org> Subject: Re: [edk2] [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal catenation in info messages
On 03/20/17 03:16, Zeng, Star wrote: > I am ok with this patch. Thanks -- should I add an R-b or A-b in your name? Thanks Laszlo > > Feng and Hao, do you have any comments? > > Thanks, > Star > -----Original Message----- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Saturday, March 18, 2017 4:47 AM > To: edk2-devel-01 <edk2-devel@lists.01.org> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org>; Tian, Feng > <feng.t...@intel.com>; Wu, Hao A <hao.a...@intel.com>; Leif Lindholm > <leif.lindh...@linaro.org>; Zeng, Star <star.z...@intel.com> > Subject: [PATCH v2 03/12] MdeModulePkg/RamDiskDxe: fix C string literal > catenation in info messages > > RamDiskDxe installs the RamDiskAcpiCheck() Ready To Boot callback function. > If EFI_ACPI_TABLE_PROTOCOL and/or EFI_ACPI_SDT_PROTOCOL are not found, then > informational messages are logged, and the RAM disks are not published to the > (nonexistent) NFIT table. > > The logic is fine, but the info messages are not concatenated correctly from > multiple string literals -- the second parts are passed as (unused) arguments > to DEBUG(). Fix the typos. > > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Cc: Feng Tian <feng.t...@intel.com> > Cc: Hao Wu <hao.a...@intel.com> > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Star Zeng <star.z...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > --- > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c > b/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c > index d1dd13a8197b..b2bafc58bb71 100644 > --- a/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c > +++ b/MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDriver.c > @@ -74,7 +74,7 @@ RamDiskAcpiCheck ( > if (EFI_ERROR (Status)) { > DEBUG (( > EFI_D_INFO, > - "RamDiskAcpiCheck: Cannot locate the EFI ACPI Table Protocol,", > + "RamDiskAcpiCheck: Cannot locate the EFI ACPI Table Protocol, " > "unable to publish RAM disks to NFIT.\n" > )); > return; > @@ -91,7 +91,7 @@ RamDiskAcpiCheck ( > if (EFI_ERROR (Status)) { > DEBUG (( > EFI_D_INFO, > - "RamDiskAcpiCheck: Cannot locate the EFI ACPI Sdt Protocol,", > + "RamDiskAcpiCheck: Cannot locate the EFI ACPI Sdt Protocol, " > "unable to publish RAM disks to NFIT.\n" > )); > mAcpiTableProtocol = NULL; > -- > 2.9.3 > > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
