comments below: On 05/11/17 00:09, Brijesh Singh wrote: > Current QemuFwCfgLib.inf is used in both Pei and Dxe phases. Add Pei > and Dxe inf file to provide a seperate QemuFwCfgLib instances for Pei > and Dxe phases. > > > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Brijesh Singh <brijesh.si...@amd.com> > --- > OvmfPkg/OvmfPkgIa32.dsc | 3 > ++- > OvmfPkg/OvmfPkgIa32X64.dsc | 3 > ++- > OvmfPkg/OvmfPkgX64.dsc | 3 > ++- > OvmfPkg/Library/QemuFwCfgLib/{QemuFwCfgLib.inf => QemuFwCfgDxeLib.inf} | 6 > +++--- > OvmfPkg/Library/QemuFwCfgLib/{QemuFwCfgLib.inf => QemuFwCfgPeiLib.inf} | 6 > +++--- > OvmfPkg/Library/QemuFwCfgLib/{QemuFwCfgPeiDxe.c => QemuFwCfgDxe.c} | 0 > OvmfPkg/Library/QemuFwCfgLib/{QemuFwCfgPeiDxe.c => QemuFwCfgPei.c} | 0 > 7 files changed, 12 insertions(+), 9 deletions(-) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index 139d54aa010e..cde3d43e39a9 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -140,7 +140,7 @@ [LibraryClasses] > DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf > > SerializeVariablesLib|OvmfPkg/Library/SerializeVariablesLib/SerializeVariablesLib.inf > - QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf > + QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxeLib.inf > VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf > LoadLinuxLib|OvmfPkg/Library/LoadLinuxLib/LoadLinuxLib.inf > > MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/BaseMemEncryptSevLib.inf > @@ -257,6 +257,7 @@ [LibraryClasses.common.PEIM] > > CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandlerLib.inf > MpInitLib|UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > QemuFwCfgS3Lib|OvmfPkg/Library/QemuFwCfgS3Lib/PeiQemuFwCfgS3LibFwCfg.inf > + QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPeiLib.inf > > [LibraryClasses.common.DXE_CORE] > HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index ee6f98d68b73..8aa72718d065 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -145,7 +145,7 @@ [LibraryClasses] > DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf > > SerializeVariablesLib|OvmfPkg/Library/SerializeVariablesLib/SerializeVariablesLib.inf > - QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf > + QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxeLib.inf > VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf > LoadLinuxLib|OvmfPkg/Library/LoadLinuxLib/LoadLinuxLib.inf > > MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/BaseMemEncryptSevLib.inf > @@ -262,6 +262,7 @@ [LibraryClasses.common.PEIM] > > CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandlerLib.inf > MpInitLib|UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > QemuFwCfgS3Lib|OvmfPkg/Library/QemuFwCfgS3Lib/PeiQemuFwCfgS3LibFwCfg.inf > + QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPeiLib.inf > > [LibraryClasses.common.DXE_CORE] > HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index b5f26e06e60b..963d394662ab 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -145,7 +145,7 @@ [LibraryClasses] > DpcLib|MdeModulePkg/Library/DxeDpcLib/DxeDpcLib.inf > UefiUsbLib|MdePkg/Library/UefiUsbLib/UefiUsbLib.inf > > SerializeVariablesLib|OvmfPkg/Library/SerializeVariablesLib/SerializeVariablesLib.inf > - QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf > + QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxeLib.inf > VirtioLib|OvmfPkg/Library/VirtioLib/VirtioLib.inf > LoadLinuxLib|OvmfPkg/Library/LoadLinuxLib/LoadLinuxLib.inf > > MemEncryptSevLib|OvmfPkg/Library/BaseMemEncryptSevLib/BaseMemEncryptSevLib.inf > @@ -262,6 +262,7 @@ [LibraryClasses.common.PEIM] > > CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandlerLib.inf > MpInitLib|UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf > QemuFwCfgS3Lib|OvmfPkg/Library/QemuFwCfgS3Lib/PeiQemuFwCfgS3LibFwCfg.inf > + QemuFwCfgLib|OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPeiLib.inf > > [LibraryClasses.common.DXE_CORE] > HobLib|MdePkg/Library/DxeCoreHobLib/DxeCoreHobLib.inf > diff --git a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf > b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxeLib.inf > similarity index 83% > copy from OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf > copy to OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxeLib.inf > index 689476032d39..346bb881ffc1 100644 > --- a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf > +++ b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxeLib.inf > @@ -19,10 +19,10 @@ > [Defines] > INF_VERSION = 0x00010005 > BASE_NAME = QemuFwCfgLib
(1) Please update this to "QemuFwCfgDxeLib". > - FILE_GUID = fdd53716-31e1-4acc-9007-8bd5d877c96f > + FILE_GUID = 80474090-55e7-4c28-b25c-9f236ba41f28 > MODULE_TYPE = BASE > VERSION_STRING = 1.0 > - LIBRARY_CLASS = QemuFwCfgLib|PEIM DXE_DRIVER > DXE_RUNTIME_DRIVER DXE_SMM_DRIVER > + LIBRARY_CLASS = QemuFwCfgLib|DXE_DRIVER > DXE_RUNTIME_DRIVER DXE_SMM_DRIVER > > CONSTRUCTOR = QemuFwCfgInitialize > > @@ -35,7 +35,7 @@ [Defines] > [Sources] > QemuFwCfgLibInternal.h > QemuFwCfgLib.c > - QemuFwCfgPeiDxe.c > + QemuFwCfgDxe.c > > [Packages] > MdePkg/MdePkg.dec > diff --git a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf > b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPeiLib.inf > similarity index 83% > rename from OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf > rename to OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPeiLib.inf > index 689476032d39..4f966a85088a 100644 > --- a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgLib.inf > +++ b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPeiLib.inf > @@ -19,10 +19,10 @@ > [Defines] > INF_VERSION = 0x00010005 > BASE_NAME = QemuFwCfgLib (2) Please update this to "QemuFwCfgPeiLib". With those changes: Reviewed-by: Laszlo Ersek <ler...@redhat.com> Thanks, Laszlo > - FILE_GUID = fdd53716-31e1-4acc-9007-8bd5d877c96f > + FILE_GUID = ddd4f5f0-5304-42a8-9efa-d14bf11a3533 > MODULE_TYPE = BASE > VERSION_STRING = 1.0 > - LIBRARY_CLASS = QemuFwCfgLib|PEIM DXE_DRIVER > DXE_RUNTIME_DRIVER DXE_SMM_DRIVER > + LIBRARY_CLASS = QemuFwCfgLib|PEIM > > CONSTRUCTOR = QemuFwCfgInitialize > > @@ -35,7 +35,7 @@ [Defines] > [Sources] > QemuFwCfgLibInternal.h > QemuFwCfgLib.c > - QemuFwCfgPeiDxe.c > + QemuFwCfgPei.c > > [Packages] > MdePkg/MdePkg.dec > diff --git a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPeiDxe.c > b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c > similarity index 100% > copy from OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPeiDxe.c > copy to OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgDxe.c > diff --git a/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPeiDxe.c > b/OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPei.c > similarity index 100% > rename from OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPeiDxe.c > rename to OvmfPkg/Library/QemuFwCfgLib/QemuFwCfgPei.c > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel