Reviewed-by: jiewen....@intel.com > -----Original Message----- > From: Zeng, Star > Sent: Monday, June 5, 2017 12:51 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star <star.z...@intel.com>; Yao, Jiewen <jiewen....@intel.com>; Bret > Barkelew <bret.barke...@microsoft.com> > Subject: [PATCH] MdePkg SmmMemLib: Remove ASSERT in > SmmIsBufferOutsideSmmValid > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=577 > > Currently the SmmIsBufferOutsideSmmValid() function in SmmMemLib.c will > ASSERT in certain conditions. Since this function is a "test" function, > it should not be making decisions on how to handle a failure. > Handling a failure should be left to the caller. > > This patch is to remove ASSERT(FALSE) at line 178 of SmmMemLib.c. > > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Bret Barkelew <bret.barke...@microsoft.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Star Zeng <star.z...@intel.com> > --- > MdePkg/Library/SmmMemLib/SmmMemLib.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/MdePkg/Library/SmmMemLib/SmmMemLib.c > b/MdePkg/Library/SmmMemLib/SmmMemLib.c > index b4e3156cb42a..db55a1a6c150 100644 > --- a/MdePkg/Library/SmmMemLib/SmmMemLib.c > +++ b/MdePkg/Library/SmmMemLib/SmmMemLib.c > @@ -6,7 +6,7 @@ > all SMRAM range via SMM_ACCESS2_PROTOCOL, including the range for > firmware (like SMM Core > and SMM driver) and/or specific dedicated hardware. > > - Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR> > + Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.<BR> > This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD > License > which accompanies this distribution. The full text of the license may be > found at > @@ -175,7 +175,6 @@ SmmIsBufferOutsideSmmValid ( > Buffer, > Length > )); > - ASSERT (FALSE); > return FALSE; > } > } > -- > 2.7.0.windows.1
_______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
