On Wed, Jun 21, 2017 at 01:31:15PM +0200, Ard Biesheuvel wrote:
> > "-pipe" isn't used anywhere else in "tools_def.template". Can we imagine
> > a platform where cross-compiling to aarch64 with gcc works otherwise,
> > but "-pipe" might break that? Cygwin perhaps? (No clue, honestly.)
> >
> > For consistency with the rest of "tools_def.template", I'd suggest
> > simply dropping "-save-temps", and thinking about "-pipe" separately
> > (and then for all the GCC toolchains and for all arches). But, I don't
> > feel particularly strongly about this.
> >
>
> Yeah, that's a fair point. The fact that -save-temps is specific to
> ARM does not mean we should perpetuate that with -pipe.
>
> Leif, if you agree, I will drop the addition of -pipe from this patch,
> and we can revisit it later for all GCC flavors.
Much as I would like to find out if there really are any platforms
that still have issues with -pipe (in which case, why wouldn't GCC
just use temp files anyway?), I guess that is a sensible approach.
Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org>
for the dropping of -save-temps.
/
Leif
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
