Reviewed-by: Liming Gao <liming....@intel.com> > -----Original Message----- > From: Zhu, Yonghong > Sent: Thursday, August 3, 2017 5:00 PM > To: edk2-devel@lists.01.org > Cc: Gao, Liming <liming....@intel.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; Fan, Jeff <jeff....@intel.com>; Andrew > Fish <af...@apple.com> > Subject: [Patch V2 3/4] IntelFrameworkModulePkg: Fix Xcode 9 Beta treating > 32-bit left shift as undefined > > Bug: https://bugzilla.tianocore.org/show_bug.cgi?id=635 > > Cc: Liming Gao <liming....@intel.com> > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Jeff Fan <jeff....@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Andrew Fish <af...@apple.com> > --- > .../BaseUefiTianoCustomDecompressLib.c | 6 > +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git > a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.c > b/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.c > index e0ba053..5d64f02 100644 > --- > a/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.c > +++ > b/IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.c > @@ -28,18 +28,18 @@ FillBuf ( > ) > { > // > // Left shift NumOfBits of bits in advance > // > - Sd->mBitBuf = (UINT32) (Sd->mBitBuf << NumOfBits); > + Sd->mBitBuf = (UINT32) LShiftU64 (((UINT64)Sd->mBitBuf), NumOfBits); > > // > // Copy data needed in bytes into mSbuBitBuf > // > while (NumOfBits > Sd->mBitCount) { > - > - Sd->mBitBuf |= (UINT32) (Sd->mSubBitBuf << (NumOfBits = (UINT16) > (NumOfBits - Sd->mBitCount))); > + NumOfBits = (UINT16) (NumOfBits - Sd->mBitCount); > + Sd->mBitBuf |= (UINT32) LShiftU64 (((UINT64)Sd->mSubBitBuf), NumOfBits); > > if (Sd->mCompSize > 0) { > // > // Get 1 byte into SubBitBuf > // > -- > 2.6.1.windows.1
_______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
