On 08/10/17 20:41, Brijesh Singh wrote:
> Hi Laszlo,
>
> On 08/09/2017 12:09 PM, Laszlo Ersek wrote:
> [Snip]
>
>>
>>> +
>>> +EFI_STATUS
>>> +EFIAPI
>>> +VirtioPciUnmapSharedBuffer (
>>> + VIRTIO_DEVICE_PROTOCOL *This,
>>> + VOID *Mapping
>>> + )
>>> +{
>>> + return EFI_SUCCESS;
>>> +}
>>>
>>
>> (9) Please refresh the function signatures in both "VirtioPciDevice.h"
>> and "VirtioPciFunctions.c", from the protocol definition in
>> "OvmfPkg/Include/Protocol/VirtioDevice.h".
>>
>> In particular, all the IN and OUT decoration is missing here.
>
> I see that several functions defined in VirtioPciDevice.h is missing IN
> and OUT,
Ouch, you are right!
> do you want me to send a separate patch to fix that too ?
That would be very kind of you.
Thanks!
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
