Bell Song, Why is it documented as a "Dummy" function?
There must be a reference to this symbol somewhere or it would not generate a link error. The implementation is an empty function. Is that a better way to describe this function? Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On > Behalf Of Song, BinX > Sent: Sunday, August 20, 2017 11:35 PM > To: Yao, Jiewen <jiewen....@intel.com> > Cc: edk2-devel@lists.01.org > Subject: [edk2] [PATCH V2] IntelFsp2Pkg: Fix build error with > WHOLEARCHIVE option > > V2: > - Recover TempRamInitApi API and add dummy TempRamInitApi > function to fix > build error with WHOLEARCHIVE option > > V1: > - Delete useless external TempRamInitApi API to fix > /WHOLEARCHIVE build > error with VS2015 tool chain > > Cc: Jiewen Yao <jiewen....@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Bell Song <binx.s...@intel.com> > --- > IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm | 10 ++++++++++ > IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm | 10 ++++++++++ > 2 files changed, 20 insertions(+) > > diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm > b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm > index 9744e16..81b531e 100644 > --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm > +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm > @@ -195,6 +195,16 @@ ASM_PFX(AsmGetPeiCoreOffset): > ret > > ;-------------------------------------------------------------- > -------------- > +; TempRamInit API > +; > +; Dummy function for VS2015 WHOLEARCHIVE build option > +; > +;-------------------------------------------------------------- > -------------- > +global ASM_PFX(TempRamInitApi) > +ASM_PFX(TempRamInitApi): > + ret > + > +;-------------------------------------------------------------- > -------------- > ; Module Entrypoint API > ;-------------------------------------------------------------- > -------------- > global ASM_PFX(_ModuleEntryPoint) > diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm > b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm > index cdc1149..06a791f 100644 > --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm > +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryS.nasm > @@ -54,6 +54,16 @@ ASM_PFX(FspApiCommonContinue): > ret > > ;-------------------------------------------------------------- > -------------- > +; TempRamInit API > +; > +; Dummy function for VS2015 WHOLEARCHIVE build option > +; > +;-------------------------------------------------------------- > -------------- > +global ASM_PFX(TempRamInitApi) > +ASM_PFX(TempRamInitApi): > + ret > + > +;-------------------------------------------------------------- > -------------- > ; Module Entrypoint API > ;-------------------------------------------------------------- > -------------- > global ASM_PFX(_ModuleEntryPoint) > -- > 2.10.2.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
