Reviewed-by: Fu Siyuan <siyuan...@intel.com> -----Original Message----- From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Jiaxin Wu Sent: Friday, September 1, 2017 8:51 AM To: edk2-devel@lists.01.org Cc: Ye, Ting <ting...@intel.com>; Fu, Siyuan <siyuan...@intel.com>; Wu, Jiaxin <jiaxin...@intel.com> Subject: [edk2] [Patch] NetworkPkg/IScsiDxe: Fix the incorrect max length of IP_ADDRESS.
When creating the ISCSI string OpCode for IP_ADDRESS, the max length should be IP(4)_STR_MAX_SIZE instead of IP(4)_MAX_SIZE. Cc: Ye Ting <ting...@intel.com> Cc: Fu Siyuan <siyuan...@intel.com> Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Wu Jiaxin <jiaxin...@intel.com> --- NetworkPkg/IScsiDxe/IScsiMisc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/NetworkPkg/IScsiDxe/IScsiMisc.c b/NetworkPkg/IScsiDxe/IScsiMisc.c index e20fe91..efd05cf 100644 --- a/NetworkPkg/IScsiDxe/IScsiMisc.c +++ b/NetworkPkg/IScsiDxe/IScsiMisc.c @@ -1007,11 +1007,11 @@ IScsiCreateKeywords ( StringToken, StringToken, 0, 0, IP4_MIN_SIZE, - IP4_MAX_SIZE, + IP4_STR_MAX_SIZE, NULL ); // // Create iSCSIInitiatorNetmask Keyword. @@ -1033,11 +1033,11 @@ IScsiCreateKeywords ( StringToken, StringToken, 0, 0, IP4_MIN_SIZE, - IP4_MAX_SIZE, + IP4_STR_MAX_SIZE, NULL ); // // Create iSCSIInitiatorGateway Keyword. @@ -1059,11 +1059,11 @@ IScsiCreateKeywords ( StringToken, StringToken, 0, 0, IP4_MIN_SIZE, - IP4_MAX_SIZE, + IP4_STR_MAX_SIZE, NULL ); // // Create iSCSITargetInfoViaDHCP Keyword. @@ -1165,11 +1165,11 @@ IScsiCreateKeywords ( StringToken, StringToken, 0, 0, IP_MIN_SIZE, - IP_MAX_SIZE, + IP_STR_MAX_SIZE, NULL ); // // Create iSCSILUN Keyword. -- 1.9.5.msysgit.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel