Thanks to catch this.
Reviewed-by: jiewen....@intel.com
> -----Original Message-----
> From: Chiu, Chasel
> Sent: Thursday, September 14, 2017 10:44 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen....@intel.com>; Chiu, Chasel <chasel.c...@intel.com>
> Subject: [PATCH] IntelFsp2Pkg-Tools: GenCfgOpt.py shouldn't include specific
> UPD name
>
> PcdSerialIoUartDebugEnable UPD is platform specific and should not
> be included in generic GenCfgOpt.py script. Remove this and platform
> DSC should control the default value instead.
>
> Cc: Jiewen Yao <jiewen....@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Chasel Chiu <chasel.c...@intel.com>
> ---
> IntelFsp2Pkg/Tools/GenCfgOpt.py | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/IntelFsp2Pkg/Tools/GenCfgOpt.py
> b/IntelFsp2Pkg/Tools/GenCfgOpt.py
> index 6dc1b10b34..c9b7bc5373 100644
> --- a/IntelFsp2Pkg/Tools/GenCfgOpt.py
> +++ b/IntelFsp2Pkg/Tools/GenCfgOpt.py
> @@ -289,7 +289,6 @@ class CGenCfgOpt:
> def __init__(self):
> self.Debug = False
> self.Error = ''
> - self.ReleaseMode = True
>
> self._GlobalDataDef = """
> GlobalDataDef
> @@ -318,13 +317,6 @@ EndList
> self._FvDir = ''
> self._MapVer = 0
>
> - def ParseBuildMode (self, OutputStr):
> - if "RELEASE_" in OutputStr:
> - self.ReleaseMode = True
> - if "DEBUG_" in OutputStr:
> - self.ReleaseMode = False
> - return
> -
> def ParseMacros (self, MacroDefStr):
> # ['-DABC=1', '-D', 'CFG_DEBUG=1', '-D', 'CFG_OUTDIR=Build']
> self._MacroDict = {}
> @@ -815,9 +807,6 @@ EndList
>
> TxtFd.write("%s.UnusedUpdSpace%d|%s0x%04X|0x%04X|{0}\n" %
> (Item['space'], SpaceIdx, Default, NextOffset - StartAddr, Offset -
> NextOffset))
> SpaceIdx = SpaceIdx + 1
> NextOffset = Offset + Item['length']
> - if Item['cname'] == 'PcdSerialIoUartDebugEnable':
> - if self.ReleaseMode == False:
> - Item['value'] = 0x01
> TxtFd.write("%s.%s|%s0x%04X|%s|%s\n" %
> (Item['space'],Item['cname'],Default,Item['offset'] -
> StartAddr,Item['length'],Item['value']))
> TxtFd.close()
> return 0
> @@ -1437,7 +1426,6 @@ def Main():
> print "ERROR: Macro parsing failed !"
> return 3
>
> - GenCfgOpt.ParseBuildMode(sys.argv[3])
> FvDir = sys.argv[3]
> if not os.path.exists(FvDir):
> os.makedirs(FvDir)
> --
> 2.13.3.windows.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
