One minor comment, please shorten the subject of the patch. Maybe like: UefiCpuPkg/CpuDxe: Fix GCC build error on commit c1cab54
With that change, Reviewed-by: Hao Wu <hao.a...@intel.com> Best Regards, Hao Wu > -----Original Message----- > From: Wang, Jian J > Sent: Friday, September 22, 2017 10:15 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A; Anthony PERARD > Subject: [PATCH] UefiCpuPkg/CpuDxe: Fix GCC build error on commit > c1cab54ce57c2608b8b3ea051c7041f036f21153 > > Cc: Hao Wu <hao.a...@intel.com> > Cc: Anthony PERARD <anthony.per...@citrix.com> > Suggested-by: Jiewen Yao <jiewen....@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jian J Wang <jian.j.w...@intel.com> > --- > UefiCpuPkg/CpuDxe/CpuPageTable.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.c > b/UefiCpuPkg/CpuDxe/CpuPageTable.c > index ae93f3f553..d312eb66f8 100644 > --- a/UefiCpuPkg/CpuDxe/CpuPageTable.c > +++ b/UefiCpuPkg/CpuDxe/CpuPageTable.c > @@ -802,8 +802,12 @@ RefreshGcdMemoryAttributesFromPaging ( > > GetCurrentPagingContext (&PagingContext); > > - BaseAddress = 0; > - PageLength = 0; > + DoUpdate = FALSE; > + Capabilities = 0; > + Attributes = 0; > + BaseAddress = 0; > + PageLength = 0; > + > for (Index = 0; Index < NumberOfDescriptors; Index++) { > if (MemorySpaceMap[Index].GcdMemoryType == > EfiGcdMemoryTypeNonExistent) { > continue; > -- > 2.14.1.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel