Reviewed-by: Jian J Wang <jian.j.w...@intel.com>
> -----Original Message----- > From: Bi, Dandan > Sent: Friday, October 20, 2017 9:00 AM > To: edk2-devel@lists.01.org > Cc: Wang, Jian J <jian.j.w...@intel.com>; Gao, Liming <liming....@intel.com> > Subject: [patch 2/4] IntelFrameworkModule/LegacyBios: Avoid explicit > comparison for BOOLEAN > > Cc: Jian J Wang <jian.j.w...@intel.com> > Cc: Liming Gao <liming....@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi <dandan...@intel.com> > --- > IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios.c > b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios.c > index e009999..c6461f5 100644 > --- a/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios.c > +++ b/IntelFrameworkModulePkg/Csm/LegacyBiosDxe/LegacyBios.c > @@ -804,11 +804,11 @@ EnableNullDetection ( > EFI_STATUS Status; > EFI_GCD_MEMORY_SPACE_DESCRIPTOR Desc; > > if (((PcdGet8 (PcdNullPointerDetectionPropertyMask) & BIT0) == 0) > || > - ((mEndOfDxe == TRUE) && > + ((mEndOfDxe) && > ((PcdGet8 (PcdNullPointerDetectionPropertyMask) & (BIT7|BIT0)) > == (BIT7|BIT0))) > ) { > return; > } > @@ -854,11 +854,11 @@ DisableNullDetection ( > EFI_STATUS Status; > EFI_GCD_MEMORY_SPACE_DESCRIPTOR Desc; > > if (((PcdGet8 (PcdNullPointerDetectionPropertyMask) & BIT0) == 0) > || > - ((mEndOfDxe == TRUE) && > + ((mEndOfDxe) && > ((PcdGet8 (PcdNullPointerDetectionPropertyMask) & (BIT7|BIT0)) > == (BIT7|BIT0))) > ) { > return; > } > -- > 1.9.5.msysgit.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel