Hi Laszlo, I happen hope to know how to well test the IOMMU/VT-D feature on OVMF. Can you give me some hints?
Steven Shi Intel\SSG\STO\UEFI Firmware Tel: +86 021-61166522 iNet: 821-6522 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Laszlo Ersek > Sent: Tuesday, October 24, 2017 6:53 PM > To: edk2-devel-01 <edk2-devel@lists.01.org> > Cc: Ni, Ruiyu <ruiyu...@intel.com>; Dong, Eric <eric.d...@intel.com>; > Andrew Fish <af...@apple.com>; Leif Lindholm <leif.lindh...@linaro.org>; > Kinney, Michael D <michael.d.kin...@intel.com> > Subject: [edk2] [PATCH] Maintainers.txt: add Laszlo Ersek as UefiCpuPkg > reviewer > > UefiCpuPkg hosts a number of modules (SMM infrastructure, > MP-initialization) that may behave differently enough between > virtualization guests and physical boards that they merit regression > testing and review specifically from a virtualization perspective. > > Add Laszlo as a UefiCpuPkg reviewer (not maintainer) so that he be CC'd on > all UefiCpuPkg patches. > > > R: Package Reviewer: Cc address for patches and questions. Reviewers > > help maintainers review code, but don't have push access. > > Cc: Andrew Fish <af...@apple.com> > Cc: Eric Dong <eric.d...@intel.com> > Cc: Jeff Fan <vanjeff_...@hotmail.com> > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Michael D Kinney <michael.d.kin...@intel.com> > Cc: Ruiyu Ni <ruiyu...@intel.com> > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > --- > > Notes: > Recently there have been two UefiCpuPkg patches on the list that have > each spent hardly more than 24 hours in review: > > * d76c2da8d50d ("MdeModulePkg/PiSmmCore: Install Protocol when S3 > resume > finished.", 2017-10-11), > > * 0594ec417c89 ("UefiCpuPkg/MpInitLib: Enhance waiting for AP > initialization logic.", 2017-10-23). > > Both times, I was out of office, and didn't get a chance to comment. The > first commit broke OVMF: > > http://mid.mail-archive.com/8d678707-fb07-0326-acfd- > 878bb7e8c...@redhat.com > https://github.com/tianocore/edk2/commit/152e8d7670d5 > > while the second commit has a good chance to break OVMF on at least > some > virt hosts: > > https://lists.01.org/pipermail/edk2-devel/2017-October/016309.html > > I was not CC'd either time. Had I been CC'd, the automated out-of-office > reply that I always set up would have been received on the submitter's > side, and I could have tested and/or commented on the patches in > question, before they were pushed. > > My intent as a UefiCpuPkg Reviewer is to be inserted in the patch review > process for UefiCpuPkg. I should be explicitly CC'd; and my feedback > should please be waited upon. I think I've proved myself reasonably > responsive; I intend to follow up in a few days every time. My review > should definitely not replace Eric's review, but I'd like to get an > *official* chance to raise questions before a patch is pushed. Whenever > I have nothing to add, I'll send an Acked-by. Thanks. > > Maintainers.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > index c1a5723af9db..297a9bfd2b56 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -245,6 +245,7 @@ M: Jaben Carsey <jaben.car...@intel.com> > UefiCpuPkg > W: https://github.com/tianocore/tianocore.github.io/wiki/UefiCpuPkg > M: Eric Dong <eric.d...@intel.com> > +R: Laszlo Ersek <ler...@redhat.com> > > UnixPkg > W: https://github.com/tianocore/tianocore.github.io/wiki/UnixPkg > -- > 2.14.1.3.gb7cf6e02401b > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
