Sorry, let me clarify, if we believe C4255 can help catch more problem, and we fixed all problem, why not enable it in BaseTool directly.
> -----Original Message----- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of Yao, > Jiewen > Sent: Tuesday, November 7, 2017 1:44 PM > To: Song, BinX <binx.s...@intel.com>; edk2-devel@lists.01.org > Cc: Gao, Liming <liming....@intel.com> > Subject: Re: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 > warning > > Yes, I suggest we fix it. > > > -----Original Message----- > > From: Song, BinX > > Sent: Tuesday, November 7, 2017 1:43 PM > > To: Yao, Jiewen <jiewen....@intel.com>; edk2-devel@lists.01.org > > Cc: Gao, Liming <liming....@intel.com> > > Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 warning > > > > Hi Jiewen, > > > > Do you mean we fix the problem after enable MSFT C4255 warning? > > If yes, I have fix them in related patch, such as MdeModulePkg. > > > > Best Regards, > > Bell Song > > > > > > > -----Original Message----- > > > From: Yao, Jiewen > > > Sent: Tuesday, November 7, 2017 1:39 PM > > > To: Song, BinX <binx.s...@intel.com>; edk2-devel@lists.01.org > > > Cc: Gao, Liming <liming....@intel.com> > > > Subject: RE: [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 > > > warning > > > > > > Hi > > > I suggest we fix the problem. > > > > > > > -----Original Message----- > > > > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > > > Song, > > > > BinX > > > > Sent: Tuesday, November 7, 2017 1:35 PM > > > > To: edk2-devel@lists.01.org > > > > Cc: Gao, Liming <liming....@intel.com> > > > > Subject: [edk2] [PATCH 05/14] IntelFsp2WrapperPkg: Enable MSFT C4255 > > > warning > > > > > > > > Enable MSFT C4255 warning > > > > > > > > From MSDN: > > > > Compiler Warning (level 4) C4255 > > > > function' : no function prototype given: converting '()' to '(void)' > > > > The compiler did not find an explicit list of arguments to a function. > > > > This warning is for the C compiler only. > > > > > > > > Cc: Liming Gao <liming....@intel.com> > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > Signed-off-by: Bell Song <binx.s...@intel.com> > > > > --- > > > > IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc > > > > b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc > > > > index 6496dad..4b4d5b2 100644 > > > > --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc > > > > +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc > > > > @@ -95,3 +95,4 @@ > > > > > > > > [BuildOptions] > > > > *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES > > > > + MSFT:*_*_*_CC_FLAGS = /we4255 > > > > -- > > > > 2.10.2.windows.1 > > > > > > > > _______________________________________________ > > > > edk2-devel mailing list > > > > edk2-devel@lists.01.org > > > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
